Re: [PATCH v3 15/17] linux-user/strace: Fix print_syscall_err

2022-03-17 Thread Pierre Muller
Hello Richard, being mainly a Pascal programmer, I always jump when I see such constructs: You change the type of the print_syscall_err parameter to abi_ulong, with is an unsigned type as the name suggests, and after you compare it to a signed constant -4096. This would never work in Pasc

[PATCH v3 15/17] linux-user/strace: Fix print_syscall_err

2022-03-15 Thread Richard Henderson
Errors are not all negative numbers, but only the top 4k. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/strace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 2cdbf030ba..f235118fb6 1