Re: [PATCH v3 15/38 6/6] target/s390x: Improve general case of disas_jcc

2024-01-22 Thread Ilya Leoshkevich
On Sat, Jan 20, 2024 at 12:23:02AM +0100, Philippe Mathieu-Daudé wrote: > From: Richard Henderson > > Avoid code duplication by handling 7 of the 14 cases > by inverting the test for the other 7 cases. > > Use TCG_COND_TSTNE for cc in {1,3}. > Use (cc - 1) <= 1 for cc in {1,2}. > >

Re: [PATCH v3 15/38 6/6] target/s390x: Improve general case of disas_jcc

2024-01-19 Thread Philippe Mathieu-Daudé
On 20/1/24 00:23, Philippe Mathieu-Daudé wrote: From: Richard Henderson Avoid code duplication by handling 7 of the 14 cases by inverting the test for the other 7 cases. Use TCG_COND_TSTNE for cc in {1,3}. Use (cc - 1) <= 1 for cc in {1,2}. Signed-off-by: Richard Henderson Signed-off-by:

[PATCH v3 15/38 6/6] target/s390x: Improve general case of disas_jcc

2024-01-19 Thread Philippe Mathieu-Daudé
From: Richard Henderson Avoid code duplication by handling 7 of the 14 cases by inverting the test for the other 7 cases. Use TCG_COND_TSTNE for cc in {1,3}. Use (cc - 1) <= 1 for cc in {1,2}. Signed-off-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé ---