Re: [PATCH v3 2/4] bitmap: Enforce maximum bitmap name length

2019-11-15 Thread Vladimir Sementsov-Ogievskiy
15.11.2019 19:33, Eric Blake wrote: > On 11/15/19 9:47 AM, Vladimir Sementsov-Ogievskiy wrote: >> 15.11.2019 18:03, Vladimir Sementsov-Ogievskiy wrote: >>> 14.11.2019 5:46, Eric Blake wrote: We document that for qcow2 persistent bitmaps, the name cannot exceed 1023 bytes.  It is

Re: [PATCH v3 2/4] bitmap: Enforce maximum bitmap name length

2019-11-15 Thread Eric Blake
On 11/15/19 9:47 AM, Vladimir Sementsov-Ogievskiy wrote: 15.11.2019 18:03, Vladimir Sementsov-Ogievskiy wrote: 14.11.2019 5:46, Eric Blake wrote: We document that for qcow2 persistent bitmaps, the name cannot exceed 1023 bytes.  It is inconsistent if transient bitmaps do not have to abide by

Re: [PATCH v3 2/4] bitmap: Enforce maximum bitmap name length

2019-11-15 Thread Vladimir Sementsov-Ogievskiy
15.11.2019 18:03, Vladimir Sementsov-Ogievskiy wrote: > 14.11.2019 5:46, Eric Blake wrote: >> We document that for qcow2 persistent bitmaps, the name cannot exceed >> 1023 bytes.  It is inconsistent if transient bitmaps do not have to >> abide by the same limit, and it is unlikely that any

Re: [PATCH v3 2/4] bitmap: Enforce maximum bitmap name length

2019-11-15 Thread Vladimir Sementsov-Ogievskiy
14.11.2019 5:46, Eric Blake wrote: > We document that for qcow2 persistent bitmaps, the name cannot exceed > 1023 bytes. It is inconsistent if transient bitmaps do not have to > abide by the same limit, and it is unlikely that any existing client > even cares about using bitmap names this long.

Re: [PATCH v3 2/4] bitmap: Enforce maximum bitmap name length

2019-11-14 Thread Maxim Levitsky
On Wed, 2019-11-13 at 20:46 -0600, Eric Blake wrote: > We document that for qcow2 persistent bitmaps, the name cannot exceed > 1023 bytes. It is inconsistent if transient bitmaps do not have to > abide by the same limit, and it is unlikely that any existing client > even cares about using bitmap

[PATCH v3 2/4] bitmap: Enforce maximum bitmap name length

2019-11-13 Thread Eric Blake
We document that for qcow2 persistent bitmaps, the name cannot exceed 1023 bytes. It is inconsistent if transient bitmaps do not have to abide by the same limit, and it is unlikely that any existing client even cares about using bitmap names this long. It's time to codify that ALL bitmaps