Re: [PATCH v3 2/4] tests/qtest/migration: Add infrastructure to skip tests on older QEMUs

2024-01-09 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Jan 08, 2024 at 11:49:45AM -0300, Fabiano Rosas wrote: >> >> + >> >> +if (major > tgt_major) { >> >> +return -1; >> > >> > This means the QEMU version is newer, the function will return negative. >> > Is this what we want? It seems it's inverted. >> >> The

Re: [PATCH v3 2/4] tests/qtest/migration: Add infrastructure to skip tests on older QEMUs

2024-01-08 Thread Peter Xu
On Mon, Jan 08, 2024 at 11:49:45AM -0300, Fabiano Rosas wrote: > >> + > >> +if (major > tgt_major) { > >> +return -1; > > > > This means the QEMU version is newer, the function will return negative. > > Is this what we want? It seems it's inverted. > > The return "points" to which onc

Re: [PATCH v3 2/4] tests/qtest/migration: Add infrastructure to skip tests on older QEMUs

2024-01-08 Thread Daniel P . Berrangé
On Fri, Jan 05, 2024 at 03:04:47PM -0300, Fabiano Rosas wrote: > We can run the migration tests with two different QEMU binaries to > test migration compatibility between QEMU versions. This means we'll > be running the tests with an older QEMU in either source or > destination. > > We need to avo

Re: [PATCH v3 2/4] tests/qtest/migration: Add infrastructure to skip tests on older QEMUs

2024-01-08 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Jan 05, 2024 at 03:04:47PM -0300, Fabiano Rosas wrote: >> We can run the migration tests with two different QEMU binaries to >> test migration compatibility between QEMU versions. This means we'll >> be running the tests with an older QEMU in either source or >> destina

Re: [PATCH v3 2/4] tests/qtest/migration: Add infrastructure to skip tests on older QEMUs

2024-01-08 Thread Peter Xu
On Mon, Jan 08, 2024 at 04:13:10PM +0800, Peter Xu wrote: > On Fri, Jan 05, 2024 at 03:04:47PM -0300, Fabiano Rosas wrote: > > We can run the migration tests with two different QEMU binaries to > > test migration compatibility between QEMU versions. This means we'll > > be running the tests with an

Re: [PATCH v3 2/4] tests/qtest/migration: Add infrastructure to skip tests on older QEMUs

2024-01-08 Thread Peter Xu
On Fri, Jan 05, 2024 at 03:04:47PM -0300, Fabiano Rosas wrote: > We can run the migration tests with two different QEMU binaries to > test migration compatibility between QEMU versions. This means we'll > be running the tests with an older QEMU in either source or > destination. > > We need to avo

[PATCH v3 2/4] tests/qtest/migration: Add infrastructure to skip tests on older QEMUs

2024-01-05 Thread Fabiano Rosas
We can run the migration tests with two different QEMU binaries to test migration compatibility between QEMU versions. This means we'll be running the tests with an older QEMU in either source or destination. We need to avoid trying to test functionality that is unknown to the older QEMU. This cou