Re: [PATCH v3 24/30] target/mips: Move helper_cache() to tcg/sysemu/special_helper.c

2021-04-19 Thread Richard Henderson
On 4/19/21 12:18 PM, Philippe Mathieu-Daudé wrote: +#define STUB_HELPER(NAME, ...) \ +static inline void gen_helper_##NAME(__VA_ARGS__) \ +{ qemu_build_not_reached(); } Does this really work when optimization is on? I suspect you need additional cleanups before you can use

[PATCH v3 24/30] target/mips: Move helper_cache() to tcg/sysemu/special_helper.c

2021-04-19 Thread Philippe Mathieu-Daudé
Move helper_cache() to tcg/sysemu/special_helper.c. The CACHE opcode is privileged and is not accessible in user emulation. However we get a link failure when restricting the symbol to sysemu. For now, add a stub helper to satisfy linking, which abort if ever called. Signed-off-by: Philippe