Re: [PATCH v3 29/34] tcg: Reorg function calls

2022-12-06 Thread Ilya Leoshkevich
On Tue, 2022-12-06 at 09:49 -0600, Richard Henderson wrote: > On 12/6/22 09:28, Ilya Leoshkevich wrote: > > > +    switch (TCG_TARGET_CALL_ARG_I64) { > > > +    case TCG_CALL_ARG_EVEN: > > > > On a s390x host with gcc-11.0.1-0.3.1.ibm.fc34.s390x I get: > > > > FAILED:

Re: [PATCH v3 29/34] tcg: Reorg function calls

2022-12-06 Thread Richard Henderson
On 12/6/22 09:28, Ilya Leoshkevich wrote: +switch (TCG_TARGET_CALL_ARG_I64) { +case TCG_CALL_ARG_EVEN: On a s390x host with gcc-11.0.1-0.3.1.ibm.fc34.s390x I get: FAILED: libqemu-aarch64-softmmu.fa.p/tcg_tcg.c.o ../tcg/tcg.c: In function ‘init_call_layout’:

Re: [PATCH v3 29/34] tcg: Reorg function calls

2022-12-06 Thread Ilya Leoshkevich
On Thu, Dec 01, 2022 at 09:39:53PM -0800, Richard Henderson wrote: > Pre-compute the function call layout for each helper at startup. > Drop TCG_CALL_DUMMY_ARG, as we no longer need to leave gaps > in the op->args[] array. This allows several places to stop > checking for NULL TCGTemp, to which

[PATCH v3 29/34] tcg: Reorg function calls

2022-12-01 Thread Richard Henderson
Pre-compute the function call layout for each helper at startup. Drop TCG_CALL_DUMMY_ARG, as we no longer need to leave gaps in the op->args[] array. This allows several places to stop checking for NULL TCGTemp, to which TCG_CALL_DUMMY_ARG mapped. For tcg_gen_callN, loop over the arguments once.