Re: [PATCH v3 3/9] qapi: start building an 'if' predicate tree

2021-06-08 Thread Markus Armbruster
John Snow writes: > On 5/21/21 10:48 AM, Markus Armbruster wrote: >> Beware, I'm skimming, not really reviewing. >> >> John Snow writes: >> >>> On 4/29/21 9:40 AM, marcandre.lur...@redhat.com wrote: [...] index b7f475a160..59a7ee2f32 100644 --- a/scripts/qapi/common.py +++

Re: [PATCH v3 3/9] qapi: start building an 'if' predicate tree

2021-05-21 Thread John Snow
On 5/21/21 10:48 AM, Markus Armbruster wrote: Beware, I'm skimming, not really reviewing. John Snow writes: On 4/29/21 9:40 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The following patches are going to express schema 'if' conditions in a target language agnostic way.

Re: [PATCH v3 3/9] qapi: start building an 'if' predicate tree

2021-05-21 Thread Markus Armbruster
Beware, I'm skimming, not really reviewing. John Snow writes: > On 4/29/21 9:40 AM, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> The following patches are going to express schema 'if' conditions in >> a >> target language agnostic way. For that, let's start building a

Re: [PATCH v3 3/9] qapi: start building an 'if' predicate tree

2021-05-17 Thread John Snow
On 5/17/21 7:18 AM, Marc-André Lureau wrote: That's also what I thought (it was in my commit message comments). I did read them, I promise :) Repeating myself, I'd defer this, there is no urge to make the code more complex yet. It can easily be done in a following iteration. I think I can

Re: [PATCH v3 3/9] qapi: start building an 'if' predicate tree

2021-05-17 Thread Marc-André Lureau
Hi On Thu, May 13, 2021 at 1:39 AM John Snow wrote: > On 4/29/21 9:40 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > The following patches are going to express schema 'if' conditions in a > > target language agnostic way. For that, let's start building a predicate >

Re: [PATCH v3 3/9] qapi: start building an 'if' predicate tree

2021-05-12 Thread John Snow
On 4/29/21 9:40 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The following patches are going to express schema 'if' conditions in a target language agnostic way. For that, let's start building a predicate tree of the configuration options. This intermediary steps still uses

[PATCH v3 3/9] qapi: start building an 'if' predicate tree

2021-04-29 Thread marcandre . lureau
From: Marc-André Lureau The following patches are going to express schema 'if' conditions in a target language agnostic way. For that, let's start building a predicate tree of the configuration options. This intermediary steps still uses C-preprocessor expressions as the predicates: "if: [STR,