Re: [PATCH v3 5/6] i386/pc: warn if phys-bits is too low

2022-02-24 Thread Joao Martins
On 2/23/22 18:44, Joao Martins wrote: > @@ -896,6 +897,15 @@ void pc_memory_init(PCMachineState *pcms, > > x86_update_above_4g_mem_start(pcms, pci_hole64_size); > > +maxphysaddr = ((hwaddr)1 << X86_CPU(first_cpu)->phys_bits) - 1; > +maxusedaddr = x86_max_phys_addr(pcms,

[PATCH v3 5/6] i386/pc: warn if phys-bits is too low

2022-02-23 Thread Joao Martins
Default phys-bits on Qemu is TCG_PHYS_BITS (40) which is enough to address 1Tb (0xff ). On AMD platforms, if a ram-above-4g relocation happens and the CPU wasn't configured with a big enough phys-bits, warn the user. There isn't a catastrophic failure exactly, the guest will still boot,