Re: [PATCH v3 6/7] hw/misc/mps2-scc: Use the LED device

2020-06-21 Thread Richard Henderson
On 6/20/20 4:07 PM, Philippe Mathieu-Daudé wrote: > @@ -25,6 +25,7 @@ typedef struct { > > /*< public >*/ > MemoryRegion iomem; > +DeviceState *led[8]; LEDState? > +for (size_t i = 0; i < ARRAY_SIZE(s->led); i++) { > +led_set_state(LED(s->led[i]), !!extract32(v

Re: [PATCH v3 6/7] hw/misc/mps2-scc: Use the LED device

2020-06-21 Thread Philippe Mathieu-Daudé
On 6/21/20 1:07 AM, Philippe Mathieu-Daudé wrote: > Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical > Reference Manual' (100112_0200_07_en): > > 2.1 Overview of the MPS2 and MPS2+ hardware > >The MPS2 and MPS2+ FPGA Prototyping Boards contain the >following compon

[PATCH v3 6/7] hw/misc/mps2-scc: Use the LED device

2020-06-20 Thread Philippe Mathieu-Daudé
Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical Reference Manual' (100112_0200_07_en): 2.1 Overview of the MPS2 and MPS2+ hardware The MPS2 and MPS2+ FPGA Prototyping Boards contain the following components and interfaces: * User switches and user LEDs: