Re: [PATCH v4 0/3] Adjust the output of x-query-virtio-status

2024-03-15 Thread Yong Huang
On Fri, Mar 15, 2024 at 3:51 PM Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Mar 13, 2024 at 10:40:21AM +0100, Markus Armbruster wrote: > >> I could be awkward for the use case described in PATCH 1's commit > >> message: > >> > >> However, we sometimes want to

Re: [PATCH v4 0/3] Adjust the output of x-query-virtio-status

2024-03-15 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Mar 13, 2024 at 10:40:21AM +0100, Markus Armbruster wrote: >> I could be awkward for the use case described in PATCH 1's commit >> message: >> >> However, we sometimes want to compare features and status bits without >> caring for their exact

Re: [PATCH v4 0/3] Adjust the output of x-query-virtio-status

2024-03-13 Thread Michael S. Tsirkin
On Wed, Mar 13, 2024 at 10:40:21AM +0100, Markus Armbruster wrote: > I could be awkward for the use case described in PATCH 1's commit > message: > > However, we sometimes want to compare features and status bits without > caring for their exact meaning. Say we want to verify the

Re: [PATCH v4 0/3] Adjust the output of x-query-virtio-status

2024-03-13 Thread Michael S. Tsirkin
On Wed, Mar 13, 2024 at 10:40:21AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Mar 13, 2024 at 09:20:08AM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Wed, Feb 21, 2024 at 10:28:50PM +0800, Hyman Huang wrote: > >> >> v4: > >>

Re: [PATCH v4 0/3] Adjust the output of x-query-virtio-status

2024-03-13 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Mar 13, 2024 at 09:20:08AM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Wed, Feb 21, 2024 at 10:28:50PM +0800, Hyman Huang wrote: >> >> v4: >> >> - Rebase on master >> >> - Fix the syntax mistake within the commit message of

Re: [PATCH v4 0/3] Adjust the output of x-query-virtio-status

2024-03-13 Thread Michael S. Tsirkin
On Wed, Mar 13, 2024 at 09:20:08AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Feb 21, 2024 at 10:28:50PM +0800, Hyman Huang wrote: > >> v4: > >> - Rebase on master > >> - Fix the syntax mistake within the commit message of [PATCH v3 1/3] > >> - Adjust the

Re: [PATCH v4 0/3] Adjust the output of x-query-virtio-status

2024-03-13 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Feb 21, 2024 at 10:28:50PM +0800, Hyman Huang wrote: >> v4: >> - Rebase on master >> - Fix the syntax mistake within the commit message of [PATCH v3 1/3] >> - Adjust the linking file in hw/virtio/meson.build suggested by Markus >> >> Please review, >> Yong

Re: [PATCH v4 0/3] Adjust the output of x-query-virtio-status

2024-03-12 Thread Michael S. Tsirkin
On Wed, Feb 21, 2024 at 10:28:50PM +0800, Hyman Huang wrote: > v4: > - Rebase on master > - Fix the syntax mistake within the commit message of [PATCH v3 1/3] > - Adjust the linking file in hw/virtio/meson.build suggested by Markus > > Please review, > Yong I'm still not excited about this. For

[PATCH v4 0/3] Adjust the output of x-query-virtio-status

2024-02-21 Thread Hyman Huang
v4: - Rebase on master - Fix the syntax mistake within the commit message of [PATCH v3 1/3] - Adjust the linking file in hw/virtio/meson.build suggested by Markus Please review, Yong v3: - Rebase on master - Use the refined commit message furnished by Markus for [PATCH v2 1/2] - Drop the [PATCH