Re: [PATCH v4 0/9] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

2021-05-22 Thread Hervé Poussineau
Le 18/05/2021 à 09:14, Philippe Mathieu-Daudé a écrit : Cc'ing Hervé, Aleksandar, Markus & Mark. On 5/17/21 11:11 PM, John Snow wrote: On 5/17/21 4:50 PM, Philippe Mathieu-Daudé wrote: On 5/17/21 9:19 PM, John Snow wrote: On 5/17/21 2:39 PM, Philippe Mathieu-Daudé wrote: The floppy disc

Re: [PATCH v4 0/9] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

2021-05-18 Thread Philippe Mathieu-Daudé
Cc'ing Hervé, Aleksandar, Markus & Mark. On 5/17/21 11:11 PM, John Snow wrote: > On 5/17/21 4:50 PM, Philippe Mathieu-Daudé wrote: >> On 5/17/21 9:19 PM, John Snow wrote: >>> On 5/17/21 2:39 PM, Philippe Mathieu-Daudé wrote: The floppy disc controllers pulls in irrelevant devices (sysbus in

Re: [PATCH v4 0/9] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

2021-05-17 Thread John Snow
On 5/17/21 4:50 PM, Philippe Mathieu-Daudé wrote: On 5/17/21 9:19 PM, John Snow wrote: On 5/17/21 2:39 PM, Philippe Mathieu-Daudé wrote: Missing review: #1 Hi, The floppy disc controllers pulls in irrelevant devices (sysbus in an ISA-only machine, ISA bus + isa devices on a sysbus-only

Re: [PATCH v4 0/9] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

2021-05-17 Thread Philippe Mathieu-Daudé
On 5/17/21 9:19 PM, John Snow wrote: > On 5/17/21 2:39 PM, Philippe Mathieu-Daudé wrote: >> Missing review: #1 >> >> Hi, >> >> The floppy disc controllers pulls in irrelevant devices (sysbus in >> an ISA-only machine, ISA bus + isa devices on a sysbus-only machine). >> >> This series clean that by

Re: [PATCH v4 0/9] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

2021-05-17 Thread John Snow
On 5/17/21 2:39 PM, Philippe Mathieu-Daudé wrote: Missing review: #1 Hi, The floppy disc controllers pulls in irrelevant devices (sysbus in an ISA-only machine, ISA bus + isa devices on a sysbus-only machine). This series clean that by extracting each device in its own file, adding the

[PATCH v4 0/9] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

2021-05-17 Thread Philippe Mathieu-Daudé
Missing review: #1 Hi, The floppy disc controllers pulls in irrelevant devices (sysbus in an ISA-only machine, ISA bus + isa devices on a sysbus-only machine). This series clean that by extracting each device in its own file, adding the corresponding Kconfig symbols: FDC_ISA and FDC_SYSBUS.