Re: [PATCH v4 09/15] qemu-iotests: extend the check script to support valgrind for python tests

2021-05-28 Thread Emanuele Giuseppe Esposito
  sys.exit(os.EX_USAGE) +qemu_valgrind = [] +if os.environ.get('VALGRIND_QEMU') == "y" and \ +    os.environ.get('NO_VALGRIND') != "y": +    valgrind_logfile = "--log-file=" + test_dir.strip() a bit strange that you need to strip test_dir here.. Why? Yep, it's unnecessary

Re: [PATCH v4 09/15] qemu-iotests: extend the check script to support valgrind for python tests

2021-05-28 Thread Vladimir Sementsov-Ogievskiy
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Currently, the check script only parses the option and sets the VALGRIND_QEMU environmental variable to "y". Add another local python variable that prepares the command line, identical to the one provided in the test scripts. Because the

[PATCH v4 09/15] qemu-iotests: extend the check script to support valgrind for python tests

2021-05-20 Thread Emanuele Giuseppe Esposito
Currently, the check script only parses the option and sets the VALGRIND_QEMU environmental variable to "y". Add another local python variable that prepares the command line, identical to the one provided in the test scripts. Because the python script does not know in advance the valgring PID to