Re: [PATCH v4 1/1] virtio: fix the condition for iommu_platform not supported

2022-02-07 Thread Halil Pasic
On Fri, 4 Feb 2022 20:15:27 -0500 "Michael S. Tsirkin" wrote: > On Sat, Feb 05, 2022 at 01:02:05AM +0100, Halil Pasic wrote: > > On Fri, 4 Feb 2022 08:05:25 -0500 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Feb 03, 2022 at 05:06:35PM +0100, Halil Pasic wrote: > > > > On Wed, 2 Feb

Re: [PATCH v4 1/1] virtio: fix the condition for iommu_platform not supported

2022-02-04 Thread Michael S. Tsirkin
On Sat, Feb 05, 2022 at 01:02:05AM +0100, Halil Pasic wrote: > On Fri, 4 Feb 2022 08:05:25 -0500 > "Michael S. Tsirkin" wrote: > > > On Thu, Feb 03, 2022 at 05:06:35PM +0100, Halil Pasic wrote: > > > On Wed, 2 Feb 2022 20:54:38 +0100 > > > Halil Pasic wrote: > > > > > > > } > > > > @@

Re: [PATCH v4 1/1] virtio: fix the condition for iommu_platform not supported

2022-02-04 Thread Halil Pasic
On Fri, 4 Feb 2022 08:05:25 -0500 "Michael S. Tsirkin" wrote: > On Thu, Feb 03, 2022 at 05:06:35PM +0100, Halil Pasic wrote: > > On Wed, 2 Feb 2022 20:54:38 +0100 > > Halil Pasic wrote: > > > > > } > > > @@ -82,9 +78,14 @@ void virtio_bus_device_plugged(VirtIODevice *vdev, > > > Error

Re: [PATCH v4 1/1] virtio: fix the condition for iommu_platform not supported

2022-02-04 Thread Michael S. Tsirkin
On Thu, Feb 03, 2022 at 05:06:35PM +0100, Halil Pasic wrote: > On Wed, 2 Feb 2022 20:54:38 +0100 > Halil Pasic wrote: > > > } > > @@ -82,9 +78,14 @@ void virtio_bus_device_plugged(VirtIODevice *vdev, Error > > **errp) > > return; > > } > > > > +vdev_has_iommu =

Re: [PATCH v4 1/1] virtio: fix the condition for iommu_platform not supported

2022-02-03 Thread Halil Pasic
On Wed, 2 Feb 2022 20:54:38 +0100 Halil Pasic wrote: > } > @@ -82,9 +78,14 @@ void virtio_bus_device_plugged(VirtIODevice *vdev, Error > **errp) > return; > } > > +vdev_has_iommu = virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM); > if (klass->get_dma_as !=

[PATCH v4 1/1] virtio: fix the condition for iommu_platform not supported

2022-02-02 Thread Halil Pasic
The commit 04ceb61a40 ("virtio: Fail if iommu_platform is requested, but unsupported") claims to fail the device hotplug when iommu_platform is requested, but not supported by the (vhost) device. On the first glance the condition for detecting that situation looks perfect, but because a certain