Re: [PATCH v4 1/3] qmp: Support for querying stats

2022-03-21 Thread Mark Kanda
On 3/21/2022 9:55 AM, Paolo Bonzini wrote: On 3/21/22 14:50, Markus Armbruster wrote: Mark Kanda writes: Thank you Markus. On 3/11/2022 7:06 AM, Markus Armbruster wrote: Are the stats bulky enough to justfify the extra complexity of filtering? If this was only for KVM, the complexity

Re: [PATCH v4 1/3] qmp: Support for querying stats

2022-03-21 Thread Paolo Bonzini
On 3/21/22 14:50, Markus Armbruster wrote: Mark Kanda writes: Thank you Markus. On 3/11/2022 7:06 AM, Markus Armbruster wrote: Are the stats bulky enough to justfify the extra complexity of filtering? If this was only for KVM, the complexity probably isn't worth it. However, the framework

Re: [PATCH v4 1/3] qmp: Support for querying stats

2022-03-21 Thread Markus Armbruster
First: sorry for my slow response. Mark Kanda writes: > Thank you Markus. > > On 3/11/2022 7:06 AM, Markus Armbruster wrote: >> Mark Kanda writes: >> >>> Introduce QMP support for querying stats. Provide a framework for adding new >>> stats and support for the following commands: >>> >>> -

Re: [PATCH v4 1/3] qmp: Support for querying stats

2022-03-14 Thread Mark Kanda
Thank you Markus. On 3/11/2022 7:06 AM, Markus Armbruster wrote: Mark Kanda writes: Introduce QMP support for querying stats. Provide a framework for adding new stats and support for the following commands: - query-stats Returns a list of all stats per target type (only VM and vCPU to

Re: [PATCH v4 1/3] qmp: Support for querying stats

2022-03-11 Thread Daniel P . Berrangé
On Fri, Mar 11, 2022 at 02:06:46PM +0100, Markus Armbruster wrote: > Mark Kanda writes: > > > Introduce QMP support for querying stats. Provide a framework for adding new > > stats and support for the following commands: > > > > - query-stats > > Returns a list of all stats per target type (only

Re: [PATCH v4 1/3] qmp: Support for querying stats

2022-03-11 Thread Markus Armbruster
Mark Kanda writes: > Introduce QMP support for querying stats. Provide a framework for adding new > stats and support for the following commands: > > - query-stats > Returns a list of all stats per target type (only VM and vCPU to start), with > additional options for specifying stat names, vCPU

[PATCH v4 1/3] qmp: Support for querying stats

2022-02-15 Thread Mark Kanda
Introduce QMP support for querying stats. Provide a framework for adding new stats and support for the following commands: - query-stats Returns a list of all stats per target type (only VM and vCPU to start), with additional options for specifying stat names, vCPU qom paths, and providers. -