Re: [PATCH v4 11/24] net: Use virtual time for net announce

2024-03-13 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 9:12 PM AEST, Pavel Dovgalyuk wrote: > On 12.03.2024 14:05, Nicholas Piggin wrote: > > On Tue Mar 12, 2024 at 7:09 PM AEST, Pavel Dovgalyuk wrote: > >> This won't work, as needed. Announce timer can't be enabled, because > >> it is set in post_load function. Therefore

Re: [PATCH v4 11/24] net: Use virtual time for net announce

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 9:12 PM AEST, Pavel Dovgalyuk wrote: > On 12.03.2024 14:05, Nicholas Piggin wrote: > > On Tue Mar 12, 2024 at 7:09 PM AEST, Pavel Dovgalyuk wrote: > >> This won't work, as needed. Announce timer can't be enabled, because > >> it is set in post_load function. Therefore

Re: [PATCH v4 11/24] net: Use virtual time for net announce

2024-03-12 Thread Pavel Dovgalyuk
On 12.03.2024 14:05, Nicholas Piggin wrote: On Tue Mar 12, 2024 at 7:09 PM AEST, Pavel Dovgalyuk wrote: This won't work, as needed. Announce timer can't be enabled, because it is set in post_load function. Therefore announce callbacks break the replay, when virtio-net is used with snapshots.

Re: [PATCH v4 11/24] net: Use virtual time for net announce

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 7:09 PM AEST, Pavel Dovgalyuk wrote: > This won't work, as needed. Announce timer can't be enabled, because > it is set in post_load function. Therefore announce callbacks break > the replay, when virtio-net is used with snapshots. I see. Is that somehow marked as being

Re: [PATCH v4 11/24] net: Use virtual time for net announce

2024-03-12 Thread Pavel Dovgalyuk
This won't work, as needed. Announce timer can't be enabled, because it is set in post_load function. Therefore announce callbacks break the replay, when virtio-net is used with snapshots. On 11.03.2024 20:40, Nicholas Piggin wrote: Using virtual time for announce ensures that guest visible

[PATCH v4 11/24] net: Use virtual time for net announce

2024-03-11 Thread Nicholas Piggin
Using virtual time for announce ensures that guest visible effects are deterministic and don't break replay. Signed-off-by: Nicholas Piggin --- net/announce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/announce.c b/net/announce.c index 9e99044422..70b5d5e822 100644