Re: [PATCH v4 12/20] libqtest: add in-process qtest.c tx/rx handlers

2019-11-12 Thread Alexander Bulekov
On 11/6/19 11:56 AM, Stefan Hajnoczi wrote: On Wed, Oct 30, 2019 at 02:49:58PM +, Oleinik, Alexander wrote: From: Alexander Oleinik Signed-off-by: Alexander Oleinik --- There's a particularily ugly line here: qtest_client_set_tx_handler(qts, (void (*)(QTestState *s, const char*,

Re: [PATCH v4 12/20] libqtest: add in-process qtest.c tx/rx handlers

2019-11-06 Thread Stefan Hajnoczi
On Wed, Oct 30, 2019 at 02:49:58PM +, Oleinik, Alexander wrote: > From: Alexander Oleinik > > Signed-off-by: Alexander Oleinik > --- > There's a particularily ugly line here: > qtest_client_set_tx_handler(qts, > (void (*)(QTestState *s, const char*, size_t)) send); Please typedef th

[PATCH v4 12/20] libqtest: add in-process qtest.c tx/rx handlers

2019-10-30 Thread Oleinik, Alexander
From: Alexander Oleinik Signed-off-by: Alexander Oleinik --- There's a particularily ugly line here: qtest_client_set_tx_handler(qts, (void (*)(QTestState *s, const char*, size_t)) send); Since qtest.c has no knowledge of the QTestState, I'm not sure how to avoid doing this, without add