Re: [PATCH v4 2/6] block: Allow changing bs->file on reopen

2021-05-10 Thread Vladimir Sementsov-Ogievskiy
07.05.2021 17:09, Kevin Wolf wrote: Am 07.05.2021 um 09:11 hat Vladimir Sementsov-Ogievskiy geschrieben: 17.03.2021 20:15, Alberto Garcia wrote: When the x-blockdev-reopen was added it allowed reconfiguring the graph by replacing backing files, but changing the 'file' option was forbidden.

Re: [PATCH v4 2/6] block: Allow changing bs->file on reopen

2021-05-07 Thread Kevin Wolf
Am 07.05.2021 um 09:11 hat Vladimir Sementsov-Ogievskiy geschrieben: > 17.03.2021 20:15, Alberto Garcia wrote: > > When the x-blockdev-reopen was added it allowed reconfiguring the > > graph by replacing backing files, but changing the 'file' option was > > forbidden. Because of this restriction

Re: [PATCH v4 2/6] block: Allow changing bs->file on reopen

2021-05-07 Thread Vladimir Sementsov-Ogievskiy
17.03.2021 20:15, Alberto Garcia wrote: When the x-blockdev-reopen was added it allowed reconfiguring the graph by replacing backing files, but changing the 'file' option was forbidden. Because of this restriction some operations are not possible, notably inserting and removing block filters.

Re: [PATCH v4 2/6] block: Allow changing bs->file on reopen

2021-05-05 Thread Kevin Wolf
Am 17.03.2021 um 18:15 hat Alberto Garcia geschrieben: > When the x-blockdev-reopen was added it allowed reconfiguring the > graph by replacing backing files, but changing the 'file' option was > forbidden. Because of this restriction some operations are not > possible, notably inserting and

Re: [PATCH v4 2/6] block: Allow changing bs->file on reopen

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
24.03.2021 15:25, Alberto Garcia wrote: On Thu 18 Mar 2021 03:25:07 PM CET, Vladimir Sementsov-Ogievskiy wrote: static int bdrv_reopen_prepare(BDRVReopenState *reopen_state, BlockReopenQueue *queue, - Transaction

Re: [PATCH v4 2/6] block: Allow changing bs->file on reopen

2021-03-24 Thread Alberto Garcia
On Thu 18 Mar 2021 03:25:07 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> static int bdrv_reopen_prepare(BDRVReopenState *reopen_state, >> BlockReopenQueue *queue, >> - Transaction *set_backings_tran, Error >> **errp); >> +

Re: [PATCH v4 2/6] block: Allow changing bs->file on reopen

2021-03-18 Thread Vladimir Sementsov-Ogievskiy
17.03.2021 20:15, Alberto Garcia wrote: When the x-blockdev-reopen was added it allowed reconfiguring the graph by replacing backing files, but changing the 'file' option was forbidden. Because of this restriction some operations are not possible, notably inserting and removing block filters.

[PATCH v4 2/6] block: Allow changing bs->file on reopen

2021-03-17 Thread Alberto Garcia
When the x-blockdev-reopen was added it allowed reconfiguring the graph by replacing backing files, but changing the 'file' option was forbidden. Because of this restriction some operations are not possible, notably inserting and removing block filters. This patch adds support for replacing the