Re: [PATCH v4 3/4] target/ppc: Convert debug to trace events (decrementer and IRQ)

2021-09-20 Thread David Gibson
On Mon, Sep 20, 2021 at 09:42:25AM +0200, Cédric Le Goater wrote: > On 9/20/21 09:34, David Gibson wrote: > > On Mon, Sep 20, 2021 at 08:12:02AM +0200, Cédric Le Goater wrote: > > > Signed-off-by: Cédric Le Goater > > > > So.. all the functions here are called *set_irq*, but you've named the > >

Re: [PATCH v4 3/4] target/ppc: Convert debug to trace events (decrementer and IRQ)

2021-09-20 Thread Cédric Le Goater
On 9/20/21 09:34, David Gibson wrote: On Mon, Sep 20, 2021 at 08:12:02AM +0200, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater So.. all the functions here are called *set_irq*, but you've named the tracepoints *irq_set*. Yes. I did that on purpose to identify easily the PPC IRQ

Re: [PATCH v4 3/4] target/ppc: Convert debug to trace events (decrementer and IRQ)

2021-09-20 Thread David Gibson
On Mon, Sep 20, 2021 at 08:12:02AM +0200, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater So.. all the functions here are called *set_irq*, but you've named the tracepoints *irq_set*. It's not a big deal, but it seems like it would be less confusing if you flipped that around to match

[PATCH v4 3/4] target/ppc: Convert debug to trace events (decrementer and IRQ)

2021-09-20 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc.c| 169 hw/ppc/trace-events | 22 +- 2 files changed, 82 insertions(+), 109 deletions(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index a327206a0a1e..b813ef732ec1 100644 --- a/hw/ppc/ppc.c