Re: [PATCH v4 31/37] smbus-eeprom: remove PROP_PTR

2019-11-29 Thread Corey Minyard
On Fri, Nov 29, 2019 at 01:06:41PM +0400, Marc-André Lureau wrote: > Hi Corey > > On Fri, Nov 22, 2019 at 2:44 AM Corey Minyard wrote: > > > > On Wed, Nov 20, 2019 at 07:24:36PM +0400, Marc-André Lureau wrote: > > > Instead, set the initial data field directly. > > > > > > (the initial data is

Re: [PATCH v4 31/37] smbus-eeprom: remove PROP_PTR

2019-11-29 Thread Marc-André Lureau
Hi Corey On Fri, Nov 22, 2019 at 2:44 AM Corey Minyard wrote: > > On Wed, Nov 20, 2019 at 07:24:36PM +0400, Marc-André Lureau wrote: > > Instead, set the initial data field directly. > > > > (the initial data is an array of 256 bytes. As I don't know if it may > > change over time, I keep the

Re: [PATCH v4 31/37] smbus-eeprom: remove PROP_PTR

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/22/19 12:12 PM, Marc-André Lureau wrote: On Fri, Nov 22, 2019 at 3:07 PM Philippe Mathieu-Daudé wrote: On 11/20/19 4:24 PM, Marc-André Lureau wrote: Instead, set the initial data field directly. (the initial data is an array of 256 bytes. As I don't know if it may change over time, I

Re: [PATCH v4 31/37] smbus-eeprom: remove PROP_PTR

2019-11-22 Thread Marc-André Lureau
On Fri, Nov 22, 2019 at 3:07 PM Philippe Mathieu-Daudé wrote: > > On 11/20/19 4:24 PM, Marc-André Lureau wrote: > > Instead, set the initial data field directly. > > > > (the initial data is an array of 256 bytes. As I don't know if it may > > change over time, I keep the pointer to original

Re: [PATCH v4 31/37] smbus-eeprom: remove PROP_PTR

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/20/19 4:24 PM, Marc-André Lureau wrote: Instead, set the initial data field directly. (the initial data is an array of 256 bytes. As I don't know if it may change over time, I keep the pointer to original buffer as is, but it might be worth to consider to copy it instead) Signed-off-by:

Re: [PATCH v4 31/37] smbus-eeprom: remove PROP_PTR

2019-11-21 Thread Corey Minyard
On Wed, Nov 20, 2019 at 07:24:36PM +0400, Marc-André Lureau wrote: > Instead, set the initial data field directly. > > (the initial data is an array of 256 bytes. As I don't know if it may > change over time, I keep the pointer to original buffer as is, but it > might be worth to consider to copy

[PATCH v4 31/37] smbus-eeprom: remove PROP_PTR

2019-11-20 Thread Marc-André Lureau
Instead, set the initial data field directly. (the initial data is an array of 256 bytes. As I don't know if it may change over time, I keep the pointer to original buffer as is, but it might be worth to consider to copy it instead) Signed-off-by: Marc-André Lureau --- hw/i2c/smbus_eeprom.c |