Re: [PATCH v4 4/4] target/ppc: Fix 64-bit decrementer

2021-09-20 Thread David Gibson
On Mon, Sep 20, 2021 at 08:12:03AM +0200, Cédric Le Goater wrote: > The current way the mask is built can overflow with a 64-bit decrementer. > Use sextract64() to extract the signed values and remove the logic to > handle negative values which has become useless. > > Cc: Luis Fernando Fujita

RE: [PATCH v4 4/4] target/ppc: Fix 64-bit decrementer

2021-09-20 Thread Luis Fernando Fujita Pires
From: Cédric Le Goater > The current way the mask is built can overflow with a 64-bit decrementer. > Use sextract64() to extract the signed values and remove the logic to handle > negative values which has become useless. > > Cc: Luis Fernando Fujita Pires > Fixes: a8dafa525181 ("target/ppc:

Re: [PATCH v4 4/4] target/ppc: Fix 64-bit decrementer

2021-09-20 Thread David Gibson
On Mon, Sep 20, 2021 at 08:12:03AM +0200, Cédric Le Goater wrote: > The current way the mask is built can overflow with a 64-bit decrementer. > Use sextract64() to extract the signed values and remove the logic to > handle negative values which has become useless. > > Cc: Luis Fernando Fujita

[PATCH v4 4/4] target/ppc: Fix 64-bit decrementer

2021-09-20 Thread Cédric Le Goater
The current way the mask is built can overflow with a 64-bit decrementer. Use sextract64() to extract the signed values and remove the logic to handle negative values which has become useless. Cc: Luis Fernando Fujita Pires Fixes: a8dafa525181 ("target/ppc: Implement large decrementer support