Re: [PATCH v4 4/7] dump: Introduce win_dump_available()

2023-02-23 Thread Thomas Huth
On 24/02/2023 00.17, Philippe Mathieu-Daudé wrote: Remove a pair of TARGET_X86_64 #ifdef'ry by introducing the win_dump_available() method. We'll soon extract it to a stub file for non-x86 targets. Signed-off-by: Philippe Mathieu-Daudé --- dump/dump.c | 23 +--

Re: [PATCH v4 4/7] dump: Introduce win_dump_available()

2023-02-23 Thread Richard Henderson
On 2/23/23 13:17, Philippe Mathieu-Daudé wrote: @@ -2130,12 +2136,10 @@ void qmp_dump_guest_memory(bool paging, const char *file, } #endif -#ifndef TARGET_X86_64 -if (has_format && format == DUMP_GUEST_MEMORY_FORMAT_WIN_DMP) { -error_setg(errp, "Windows dump is only

[PATCH v4 4/7] dump: Introduce win_dump_available()

2023-02-23 Thread Philippe Mathieu-Daudé
Remove a pair of TARGET_X86_64 #ifdef'ry by introducing the win_dump_available() method. We'll soon extract it to a stub file for non-x86 targets. Signed-off-by: Philippe Mathieu-Daudé --- dump/dump.c | 23 +-- dump/win_dump.c | 5 + dump/win_dump.h | 3 +++ 3