Re: [PATCH v4 7/8] hw/misc/pca9552: Trace GPIO change events

2020-06-22 Thread Philippe Mathieu-Daudé
On 6/22/20 9:01 AM, Cédric Le Goater wrote: > On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote: >> Emit a trace event when a GPIO change its state. > > I understand now why you need 'pin_status'. > > We could compute 'pin_status' and 'pin_changed' in routine > pca9552_update_pin_input() when

Re: [PATCH v4 7/8] hw/misc/pca9552: Trace GPIO change events

2020-06-22 Thread Cédric Le Goater
On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote: > Emit a trace event when a GPIO change its state. I understand now why you need 'pin_status'. We could compute 'pin_status' and 'pin_changed' in routine pca9552_update_pin_input() when updating the PCA9552_INPUT0/1 register values and pass

[PATCH v4 7/8] hw/misc/pca9552: Trace GPIO change events

2020-06-20 Thread Philippe Mathieu-Daudé
Emit a trace event when a GPIO change its state. Example booting obmc-phosphor-image: $ qemu-system-arm -M witherspoon-bmc -trace pca9552_gpio_change 1592690552.687372:pca9552_gpio_change pca1 GPIO id:0 status: 0 -> 1 1592690552.690169:pca9552_gpio_change pca1 GPIO id:1 status: 0 -> 1