Rohit Shinde writes:
> Hey Markus,
>
> Thanks for the clarification! No, I do not have patches for the same. I was
> browsing through the bite sized tasks page and that did not mention these
> details. I will keep this in mind however. For now, I will leave this task
> and I might return to it
Hey Markus,
Thanks for the clarification! No, I do not have patches for the same. I was
browsing through the bite sized tasks page and that did not mention these
details. I will keep this in mind however. For now, I will leave this task
and I might return to it at a later time.
Thanks,
Rohit.
Rohit Shinde writes:
> I am just compiling with cflag set to -Wimplicit-fallthrough. I am using
> gcc.
-Wimplicit-fallthrough is the same as -Wimplicit-fallthrough=3. Our
-code is not prepared for that. What should work is
--Wimplicit-fallthrough=2.
If you have patches to make the entire
I am just compiling with cflag set to -Wimplicit-fallthrough. I am using
gcc.
On Tue, Aug 25, 2020 at 2:03 AM Markus Armbruster wrote:
> Rohit Shinde writes:
>
> > Added fallthrough comment on line 270 to prevent the compiler from
> > throwing an error while compiling with the
Rohit Shinde writes:
> Added fallthrough comment on line 270 to prevent the compiler from
> throwing an error while compiling with the -Wimplicit-fallthrough flag
None of the compilers I know warns there. Which one are you using?
Commit message style tip: use the imperative mood
Added fallthrough comment on line 270 to prevent the compiler from
throwing an error while compiling with the -Wimplicit-fallthrough flag
Signed-off-by: Rohit Shinde
---
qapi/opts-visitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index
