Re: [PATCH v5] qga: Utilize QAPI_LIST_APPEND in qmp_guest_network_get_interfaces

2021-02-08 Thread Michael Roth
On Mon, Feb 08, 2021 at 02:23:59PM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > I found another spot that can benefit from using our macros instead of > > open-coding qapi list creation. > > > > Signed-off-by: Eric Blake > > --- > > Reviewed-by: Markus Armbruster > > Mike,

Re: [PATCH v5] qga: Utilize QAPI_LIST_APPEND in qmp_guest_network_get_interfaces

2021-02-08 Thread Markus Armbruster
Eric Blake writes: > I found another spot that can benefit from using our macros instead of > open-coding qapi list creation. > > Signed-off-by: Eric Blake > --- Reviewed-by: Markus Armbruster Mike, would you like me to stick this into a QAPI pull request?

[PATCH v5] qga: Utilize QAPI_LIST_APPEND in qmp_guest_network_get_interfaces

2021-02-05 Thread Eric Blake
I found another spot that can benefit from using our macros instead of open-coding qapi list creation. Signed-off-by: Eric Blake --- Marked v5 because it missed commit 95b3a8c8a82, which was v4: https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06574.html qga/commands-posix.c | 75