Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-20 Thread Tobin Feldman-Fitzthum
On 2020-10-20 11:56, Paolo Bonzini wrote: On 20/10/20 15:54, Eduardo Habkost wrote: On Tue, Oct 20, 2020 at 11:03:51AM +0200, Paolo Bonzini wrote: On 15/10/20 16:37, to...@linux.ibm.com wrote: -static void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, Error **errp) +void *gpa2hva(MemoryRegion

Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-20 Thread Paolo Bonzini
On 20/10/20 15:54, Eduardo Habkost wrote: > On Tue, Oct 20, 2020 at 11:03:51AM +0200, Paolo Bonzini wrote: >> On 15/10/20 16:37, to...@linux.ibm.com wrote: >>> -static void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, Error **errp) >>> +void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size,

Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-20 Thread Eduardo Habkost
On Tue, Oct 20, 2020 at 11:03:51AM +0200, Paolo Bonzini wrote: > On 15/10/20 16:37, to...@linux.ibm.com wrote: > > -static void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, Error **errp) > > +void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error > > **errp) > > { > >

Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-20 Thread Paolo Bonzini
On 15/10/20 16:37, to...@linux.ibm.com wrote: > -static void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, Error **errp) > +void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **errp) > { > MemoryRegionSection mrs = memory_region_find(get_system_memory(), > -

Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-19 Thread Tobin Feldman-Fitzthum
On 2020-10-19 12:47, Eduardo Habkost wrote: On Mon, Oct 19, 2020 at 12:46:08PM -0400, Eduardo Habkost wrote: On Thu, Oct 15, 2020 at 10:37:13AM -0400, to...@linux.ibm.com wrote: [...] > diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c > index 88e3f39a1e..2d2ee54cc6 100644 > ---

Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-19 Thread Eduardo Habkost
On Thu, Oct 15, 2020 at 10:37:13AM -0400, to...@linux.ibm.com wrote: [...] > diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c > index 88e3f39a1e..2d2ee54cc6 100644 > --- a/target/i386/sev-stub.c > +++ b/target/i386/sev-stub.c > @@ -49,3 +49,8 @@ SevCapability

Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-19 Thread Eduardo Habkost
On Mon, Oct 19, 2020 at 12:46:08PM -0400, Eduardo Habkost wrote: > On Thu, Oct 15, 2020 at 10:37:13AM -0400, to...@linux.ibm.com wrote: > [...] > > diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c > > index 88e3f39a1e..2d2ee54cc6 100644 > > --- a/target/i386/sev-stub.c > > +++

Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-19 Thread Eduardo Habkost
On Thu, Oct 15, 2020 at 10:37:13AM -0400, to...@linux.ibm.com wrote: > From: Tobin Feldman-Fitzthum > > AMD SEV allows a guest owner to inject a secret blob > into the memory of a virtual machine. The secret is > encrypted with the SEV Transport Encryption Key and > integrity is guaranteed with

Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-15 Thread Brijesh Singh
On 10/15/20 9:37 AM, to...@linux.ibm.com wrote: > From: Tobin Feldman-Fitzthum > > AMD SEV allows a guest owner to inject a secret blob > into the memory of a virtual machine. The secret is > encrypted with the SEV Transport Encryption Key and > integrity is guaranteed with the Transport

[PATCH v5] sev: add sev-inject-launch-secret

2020-10-15 Thread tobin
From: Tobin Feldman-Fitzthum AMD SEV allows a guest owner to inject a secret blob into the memory of a virtual machine. The secret is encrypted with the SEV Transport Encryption Key and integrity is guaranteed with the Transport Integrity Key. Although QEMU facilitates the injection of the