Re: [PATCH v5 08/24] replay: Fix migration use of clock

2024-03-19 Thread Nicholas Piggin
On Wed Mar 20, 2024 at 6:40 AM AEST, Alex Bennée wrote: > Nicholas Piggin writes: > > > Migration reads host clocks when not holding the replay_mutex, which > > asserts when recording a trace. It seems that these migration times > > should be host times like other statistics in MigrationState. >

Re: [PATCH v5 08/24] replay: Fix migration use of clock

2024-03-19 Thread Alex Bennée
Nicholas Piggin writes: > Migration reads host clocks when not holding the replay_mutex, which > asserts when recording a trace. It seems that these migration times > should be host times like other statistics in MigrationState. s/host/CLOCK_HOST/ and s/host/CLOCK_REALTIME/ but its a confusing

[PATCH v5 08/24] replay: Fix migration use of clock

2024-03-18 Thread Nicholas Piggin
Migration reads host clocks when not holding the replay_mutex, which asserts when recording a trace. It seems that these migration times should be host times like other statistics in MigrationState. These do not require the replay_mutex. Signed-off-by: Nicholas Piggin --- migration/migration.c