Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-06-01 Thread Het Gala
On 30/05/23 5:40 pm, Daniel P. Berrangé wrote: On Tue, May 30, 2023 at 01:02:27PM +0530, Het Gala wrote: On 30/05/23 12:28 pm, Markus Armbruster wrote: Het Gala writes: [...] +## +{ 'enum': 'MigrateTransport', + 'data': ['socket', 'exec', 'rdma'] } + +## +# @MigrateExecCommand:

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Daniel P . Berrangé
On Tue, May 30, 2023 at 01:02:27PM +0530, Het Gala wrote: > > On 30/05/23 12:28 pm, Markus Armbruster wrote: > > Het Gala writes: > > > > > On 25/05/23 11:04 pm, Markus Armbruster wrote: > > > > Het Gala writes: > > > > > > > > > This patch introduces well defined MigrateAddress struct and

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Het Gala
On 30/05/23 1:02 pm, Het Gala wrote: On 30/05/23 12:28 pm, Markus Armbruster wrote: Het Gala writes: On 25/05/23 11:04 pm, Markus Armbruster wrote: Het Gala writes: This patch introduces well defined MigrateAddress struct and its related child objects. The existing argument of

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Daniel P . Berrangé
On Tue, May 30, 2023 at 02:26:23PM +0530, Het Gala wrote: > > On 30/05/23 1:26 pm, Markus Armbruster wrote: > > Het Gala writes: > > > > > On 30/05/23 12:28 pm, Markus Armbruster wrote: > > > > Het Gala writes: > > > > > > > > > On 25/05/23 11:04 pm, Markus Armbruster wrote: > > [...] > > >

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Het Gala
On 30/05/23 2:27 pm, Daniel P. Berrangé wrote: On Tue, May 30, 2023 at 01:02:27PM +0530, Het Gala wrote: On 30/05/23 12:28 pm, Markus Armbruster wrote: Het Gala writes: On 25/05/23 11:04 pm, Markus Armbruster wrote: Het Gala writes: This patch introduces well defined MigrateAddress

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Daniel P . Berrangé
On Tue, May 30, 2023 at 01:02:27PM +0530, Het Gala wrote: > > On 30/05/23 12:28 pm, Markus Armbruster wrote: > > Het Gala writes: > > > > > On 25/05/23 11:04 pm, Markus Armbruster wrote: > > > > Het Gala writes: > > > > > > > > > This patch introduces well defined MigrateAddress struct and

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Het Gala
On 30/05/23 1:26 pm, Markus Armbruster wrote: Het Gala writes: On 30/05/23 12:28 pm, Markus Armbruster wrote: Het Gala writes: On 25/05/23 11:04 pm, Markus Armbruster wrote: [...] Aside: a more powerful type system would let us extend SocketAddress with additional variants instead of

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Markus Armbruster
Het Gala writes: > On 30/05/23 12:28 pm, Markus Armbruster wrote: >> Het Gala writes: >> >>> On 25/05/23 11:04 pm, Markus Armbruster wrote: [...] Aside: a more powerful type system would let us extend SocketAddress with additional variants instead of wrapping it in a union. >>> >>>

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Het Gala
On 30/05/23 12:28 pm, Markus Armbruster wrote: Het Gala writes: On 25/05/23 11:04 pm, Markus Armbruster wrote: Het Gala writes: This patch introduces well defined MigrateAddress struct and its related child objects. The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri'

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-30 Thread Markus Armbruster
Het Gala writes: > On 25/05/23 11:04 pm, Markus Armbruster wrote: >> Het Gala writes: >> >>> This patch introduces well defined MigrateAddress struct and its related >>> child >>> objects. >>> >>> The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of >>> string type. The

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-29 Thread Het Gala
On 25/05/23 11:04 pm, Markus Armbruster wrote: Het Gala writes: This patch introduces well defined MigrateAddress struct and its related child objects. The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of string type. The current migration flow follows double

Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-25 Thread Markus Armbruster
Het Gala writes: > This patch introduces well defined MigrateAddress struct and its related child > objects. > > The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of > string type. The current migration flow follows double encoding scheme for > fetching migration

[PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-19 Thread Het Gala
This patch introduces well defined MigrateAddress struct and its related child objects. The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of string type. The current migration flow follows double encoding scheme for fetching migration parameters such as 'uri' and this is