Re: [PATCH v5 3/3] hw/ppc: Nest1 chiplet wiring

2023-11-24 Thread Nicholas Piggin
On Fri Nov 24, 2023 at 10:26 PM AEST, Cédric Le Goater wrote: > On 11/24/23 12:28, Nicholas Piggin wrote: > > On Fri Nov 24, 2023 at 8:15 PM AEST, Chalapathi V wrote: > >> This part of the patchset connects the nest1 chiplet model to p10 chip. > > > > Seems fine to me. Should it just be squashed i

Re: [PATCH v5 3/3] hw/ppc: Nest1 chiplet wiring

2023-11-24 Thread Cédric Le Goater
On 11/24/23 12:28, Nicholas Piggin wrote: On Fri Nov 24, 2023 at 8:15 PM AEST, Chalapathi V wrote: This part of the patchset connects the nest1 chiplet model to p10 chip. Seems fine to me. Should it just be squashed into patch 2? It is better to keep the model a part from the wiring because

Re: [PATCH v5 3/3] hw/ppc: Nest1 chiplet wiring

2023-11-24 Thread Nicholas Piggin
On Fri Nov 24, 2023 at 8:15 PM AEST, Chalapathi V wrote: > This part of the patchset connects the nest1 chiplet model to p10 chip. Seems fine to me. Should it just be squashed into patch 2? Thanks, Nick > > Signed-off-by: Chalapathi V > --- > include/hw/ppc/pnv_chip.h | 2 ++ > hw/ppc/pnv.c

[PATCH v5 3/3] hw/ppc: Nest1 chiplet wiring

2023-11-24 Thread Chalapathi V
This part of the patchset connects the nest1 chiplet model to p10 chip. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_chip.h | 2 ++ hw/ppc/pnv.c | 14 ++ 2 files changed, 16 insertions(+) diff --git a/include/hw/ppc/pnv_chip.h b/include/hw/ppc/pnv_chip.h index 0a