Re: [PATCH v5 4/8] multifd: Add multifd-zlib-level parameter

2020-02-13 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Thu, Jan 30, 2020 at 09:03:00AM +0100, Markus Armbruster wrote: >> Juan Quintela writes: >> >> > It will indicate which level use for compression. >> > >> > Signed-off-by: Juan Quintela >> >> This is slightly confusing (there is no zlib compression), unless you

Re: [PATCH v5 4/8] multifd: Add multifd-zlib-level parameter

2020-02-13 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Jan 30, 2020 at 09:03:00AM +0100, Markus Armbruster wrote: >> Juan Quintela writes: >> >> > It will indicate which level use for compression. >> > >> > Signed-off-by: Juan Quintela >> >> This is slightly confusing (there is no zlib compression), unless

Re: [PATCH v5 4/8] multifd: Add multifd-zlib-level parameter

2020-02-11 Thread Daniel P . Berrangé
On Thu, Jan 30, 2020 at 09:03:00AM +0100, Markus Armbruster wrote: > Juan Quintela writes: > > > It will indicate which level use for compression. > > > > Signed-off-by: Juan Quintela > > This is slightly confusing (there is no zlib compression), unless you > peek at the next patch (which adds

Re: [PATCH v5 4/8] multifd: Add multifd-zlib-level parameter

2020-01-30 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> It will indicate which level use for compression. >> >> Signed-off-by: Juan Quintela > > This is slightly confusing (there is no zlib compression), unless you > peek at the next patch (which adds zlib compression). > > Three ways to make it

Re: [PATCH v5 4/8] multifd: Add multifd-zlib-level parameter

2020-01-30 Thread Markus Armbruster
Juan Quintela writes: > It will indicate which level use for compression. > > Signed-off-by: Juan Quintela This is slightly confusing (there is no zlib compression), unless you peek at the next patch (which adds zlib compression). Three ways to make it less confusing: * Squash the two

[PATCH v5 4/8] multifd: Add multifd-zlib-level parameter

2020-01-29 Thread Juan Quintela
It will indicate which level use for compression. Signed-off-by: Juan Quintela --- migration/migration.c | 15 +++ monitor/hmp-cmds.c| 4 qapi/migration.json | 30 +++--- 3 files changed, 46 insertions(+), 3 deletions(-) diff --git