Re: [PATCH v5 5/5] virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattr

2021-03-30 Thread Luis Henriques
On Mon, Mar 29, 2021 at 03:51:51PM -0400, Vivek Goyal wrote: > On Mon, Mar 29, 2021 at 04:35:57PM +0100, Luis Henriques wrote: > > On Thu, Mar 25, 2021 at 11:38:52AM -0400, Vivek Goyal wrote: > > > When posix access acls are set on a file, it can lead to adjusting file > > > permissions (mode) as

Re: [PATCH v5 5/5] virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattr

2021-03-29 Thread Vivek Goyal
On Mon, Mar 29, 2021 at 04:35:57PM +0100, Luis Henriques wrote: > On Thu, Mar 25, 2021 at 11:38:52AM -0400, Vivek Goyal wrote: > > When posix access acls are set on a file, it can lead to adjusting file > > permissions (mode) as well. If caller does not have CAP_FSETID and it > > also does not

Re: [PATCH v5 5/5] virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattr

2021-03-29 Thread Luis Henriques
On Thu, Mar 25, 2021 at 11:38:52AM -0400, Vivek Goyal wrote: > When posix access acls are set on a file, it can lead to adjusting file > permissions (mode) as well. If caller does not have CAP_FSETID and it > also does not have membership of owner group, this will lead to clearing > SGID bit in

[PATCH v5 5/5] virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattr

2021-03-25 Thread Vivek Goyal
When posix access acls are set on a file, it can lead to adjusting file permissions (mode) as well. If caller does not have CAP_FSETID and it also does not have membership of owner group, this will lead to clearing SGID bit in mode. Current fuse code is written in such a way that it expects file