Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-11-02 Thread Markus Armbruster
Jonathan Cameron writes: > On Fri, 27 Oct 2023 06:54:39 +0200 > Markus Armbruster wrote: > >> I'm trying to fill in QMP documentation holes, and found one in commit >> 415442a1b4a (this patch). Details inline. >> >> Jonathan Cameron writes: >> >> > CXL uses PCI AER Internal errors to signal

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-10-31 Thread Jonathan Cameron via
On Fri, 27 Oct 2023 06:54:39 +0200 Markus Armbruster wrote: > I'm trying to fill in QMP documentation holes, and found one in commit > 415442a1b4a (this patch). Details inline. > > Jonathan Cameron writes: > > > CXL uses PCI AER Internal errors to signal to the host that an error has > >

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-10-26 Thread Markus Armbruster
I'm trying to fill in QMP documentation holes, and found one in commit 415442a1b4a (this patch). Details inline. Jonathan Cameron writes: > CXL uses PCI AER Internal errors to signal to the host that an error has > occurred. The host can then read more detailed status from the CXL RAS >

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-27 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 23/2/23 15:27, Jonathan Cameron wrote: >> On Thu, 23 Feb 2023 08:37:46 +0100 >> Markus Armbruster wrote: >>> Whenever you use a poisoned macro in a conditional, all the code >>> generated for this .json file (we call it a "QAPI schema module") >>> becomes

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-24 Thread Philippe Mathieu-Daudé
On 23/2/23 15:27, Jonathan Cameron wrote: On Thu, 23 Feb 2023 08:37:46 +0100 Markus Armbruster wrote: Thomas Huth writes: On 22/02/2023 19.16, Philippe Mathieu-Daudé wrote: +Thomas (meson) & Marc-André (conditional QAPI) + Markus On 22/2/23 17:49, Jonathan Cameron wrote: [...]

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-24 Thread Jonathan Cameron via
On Thu, 23 Feb 2023 14:27:48 + Jonathan Cameron wrote: > On Thu, 23 Feb 2023 08:37:46 +0100 > Markus Armbruster wrote: > > > Thomas Huth writes: > > > > > On 22/02/2023 19.16, Philippe Mathieu-Daudé wrote: > > >> +Thomas (meson) & Marc-André (conditional QAPI) > > > > > > +

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-23 Thread Jonathan Cameron via
On Thu, 23 Feb 2023 08:37:46 +0100 Markus Armbruster wrote: > Thomas Huth writes: > > > On 22/02/2023 19.16, Philippe Mathieu-Daudé wrote: > >> +Thomas (meson) & Marc-André (conditional QAPI) > > > > + Markus > > > >> On 22/2/23 17:49, Jonathan Cameron wrote: > > [...] > > >>

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-22 Thread Markus Armbruster
Thomas Huth writes: > On 22/02/2023 19.16, Philippe Mathieu-Daudé wrote: >> +Thomas (meson) & Marc-André (conditional QAPI) > > + Markus > >> On 22/2/23 17:49, Jonathan Cameron wrote: [...] >> Doesn't these need >> >>     'if': 'CONFIG_CXL_MEM_DEVICE', >> >> ? >

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-22 Thread Thomas Huth
On 22/02/2023 19.16, Philippe Mathieu-Daudé wrote: +Thomas (meson) & Marc-André (conditional QAPI) + Markus On 22/2/23 17:49, Jonathan Cameron wrote: +# Type of uncorrectable CXL error to inject. These errors are reported via +# an AER uncorrectable internal error with additional

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-22 Thread Markus Armbruster
Jonathan Cameron writes: > On Tue, 21 Feb 2023 23:15:49 +0100 > Philippe Mathieu-Daudé wrote: > >> Hi Jonathan, >> >> On 21/2/23 16:21, Jonathan Cameron wrote: >> > CXL uses PCI AER Internal errors to signal to the host that an error has >> > occurred. The host can then read more detailed

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-22 Thread Philippe Mathieu-Daudé
+Thomas (meson) & Marc-André (conditional QAPI) On 22/2/23 17:49, Jonathan Cameron wrote: +# Type of uncorrectable CXL error to inject. These errors are reported via +# an AER uncorrectable internal error with additional information logged at +# the CXL device. +# +# @cache-data-parity: Data

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-22 Thread Jonathan Cameron via
... > >>> +# Type of uncorrectable CXL error to inject. These errors are reported > >>> via > >>> +# an AER uncorrectable internal error with additional information logged > >>> at > >>> +# the CXL device. > >>> +# > >>> +# @cache-data-parity: Data error such as data parity or data ECC error

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-22 Thread Philippe Mathieu-Daudé
On 22/2/23 15:53, Jonathan Cameron wrote: On Tue, 21 Feb 2023 23:15:49 +0100 Philippe Mathieu-Daudé wrote: Hi Jonathan, On 21/2/23 16:21, Jonathan Cameron wrote: CXL uses PCI AER Internal errors to signal to the host that an error has occurred. The host can then read more detailed status

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-22 Thread Jonathan Cameron via
On Tue, 21 Feb 2023 23:15:49 +0100 Philippe Mathieu-Daudé wrote: > Hi Jonathan, > > On 21/2/23 16:21, Jonathan Cameron wrote: > > CXL uses PCI AER Internal errors to signal to the host that an error has > > occurred. The host can then read more detailed status from the CXL RAS > > capability. >

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-21 Thread Philippe Mathieu-Daudé
Hi Jonathan, On 21/2/23 16:21, Jonathan Cameron wrote: CXL uses PCI AER Internal errors to signal to the host that an error has occurred. The host can then read more detailed status from the CXL RAS capability. For uncorrectable errors: support multiple injection in one operation as this is

Re: [PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-21 Thread Dave Jiang
On 2/21/23 8:21 AM, Jonathan Cameron wrote: CXL uses PCI AER Internal errors to signal to the host that an error has occurred. The host can then read more detailed status from the CXL RAS capability. For uncorrectable errors: support multiple injection in one operation as this is needed to

[PATCH v5 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-21 Thread Jonathan Cameron via
CXL uses PCI AER Internal errors to signal to the host that an error has occurred. The host can then read more detailed status from the CXL RAS capability. For uncorrectable errors: support multiple injection in one operation as this is needed to reliably test multiple header logging support in