Re: [PATCH v6] hmp: drop Error pointer indirection in hmp_handle_error

2019-11-28 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > We don't need Error **, as all callers pass local Error object, which > isn't used after the call. Use Error * instead. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Acked-by: Dr. David Alan Gilbert Reviewed-by: Markus Armbruster

[PATCH v6] hmp: drop Error pointer indirection in hmp_handle_error

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
We don't need Error **, as all callers pass local Error object, which isn't used after the call. Use Error * instead. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Dr. David Alan Gilbert --- v6: add Dr. David's a-b include/monitor/hmp.h | 2 +- dump/dump-hmp-cmds.c | 4