Re: [PATCH v6 1/3] hw/intc: Move mtimer/mtimecmp to aclint

2022-07-25 Thread Atish Patra
On Sat, Jul 23, 2022 at 2:43 AM Andrew Jones wrote: > > On Thu, Jul 21, 2022 at 06:00:44PM -0700, Atish Patra wrote: > > Historically, The mtime/mtimecmp has been part of the CPU because > > they are per hart entities. However, they actually belong to aclint > > which is a MMIO device. > > > >

Re: [PATCH v6 1/3] hw/intc: Move mtimer/mtimecmp to aclint

2022-07-23 Thread Andrew Jones
On Thu, Jul 21, 2022 at 06:00:44PM -0700, Atish Patra wrote: > Historically, The mtime/mtimecmp has been part of the CPU because > they are per hart entities. However, they actually belong to aclint > which is a MMIO device. > > Move them to the ACLINT device. This also emulates the real hardware

[PATCH v6 1/3] hw/intc: Move mtimer/mtimecmp to aclint

2022-07-21 Thread Atish Patra
Historically, The mtime/mtimecmp has been part of the CPU because they are per hart entities. However, they actually belong to aclint which is a MMIO device. Move them to the ACLINT device. This also emulates the real hardware more closely. Reviewed-by: Anup Patel Reviewed-by: Alistair Francis