Re: [PATCH v6 1/4] Add NVMM accelerator: configure and build logic

2021-04-01 Thread Paolo Bonzini
On 01/04/21 14:17, Reinoud Zandijk wrote: Hi Paolo, thanks for the review! On Thu, Apr 01, 2021 at 10:28:19AM +0200, Paolo Bonzini wrote: On 31/03/21 22:07, Reinoud Zandijk wrote: Signed-off-by: Reinoud Zandijk Signed-off-by: Kamil Rytarowski Incorrect order for the S-o-b headers, you

Re: [PATCH v6 1/4] Add NVMM accelerator: configure and build logic

2021-04-01 Thread Reinoud Zandijk
Hi Paolo, thanks for the review! On Thu, Apr 01, 2021 at 10:28:19AM +0200, Paolo Bonzini wrote: > On 31/03/21 22:07, Reinoud Zandijk wrote: > > Signed-off-by: Reinoud Zandijk > > Signed-off-by: Kamil Rytarowski > > Incorrect order for the S-o-b headers, you should be last. Oops? there is a

Re: [PATCH v6 1/4] Add NVMM accelerator: configure and build logic

2021-04-01 Thread Paolo Bonzini
On 31/03/21 22:07, Reinoud Zandijk wrote: Signed-off-by: Reinoud Zandijk Signed-off-by: Kamil Rytarowski Incorrect order for the S-o-b headers, you should be last. --- @@ -886,7 +887,7 @@ for opt do ;; --python=*) python="$optarg" ; explicit_python=yes ;; - --sphinx-build=*)

[PATCH v6 1/4] Add NVMM accelerator: configure and build logic

2021-03-31 Thread Reinoud Zandijk
Signed-off-by: Reinoud Zandijk Signed-off-by: Kamil Rytarowski --- accel/Kconfig | 3 +++ configure | 12 +--- meson.build | 23 --- meson_options.txt | 2 ++ qemu-options.hx | 8 5 files changed, 38 insertions(+), 10 deletions(-)