Re: [PATCH v6 3/5] 9pfs: add new function v9fs_co_readdir_many()

2020-05-07 Thread Greg Kurz
On Thu, 07 May 2020 14:16:43 +0200 Christian Schoenebeck wrote: > On Montag, 4. Mai 2020 11:18:34 CEST Greg Kurz wrote: > > On Fri, 01 May 2020 16:04:41 +0200 > > > > Christian Schoenebeck wrote: > > > On Donnerstag, 30. April 2020 15:30:49 CEST Greg Kurz wrote: > > > > > > I agree that a

Re: [PATCH v6 3/5] 9pfs: add new function v9fs_co_readdir_many()

2020-05-07 Thread Christian Schoenebeck
On Montag, 4. Mai 2020 11:18:34 CEST Greg Kurz wrote: > On Fri, 01 May 2020 16:04:41 +0200 > > Christian Schoenebeck wrote: > > On Donnerstag, 30. April 2020 15:30:49 CEST Greg Kurz wrote: > > > > > I agree that a client that issues concurrent readdir requests on the > > > > > same fid is

Re: [PATCH v6 3/5] 9pfs: add new function v9fs_co_readdir_many()

2020-05-04 Thread Christian Schoenebeck
On Montag, 4. Mai 2020 11:18:34 CEST Greg Kurz wrote: > > > > > > +memcpy(e->dent, dent, sizeof(struct dirent)); > > > > > > + > > > > > > +/* perform a full stat() for directory entry if requested > > > > > > by > > > > > > caller */ +if (dostat) { > > > > > > +

Re: [PATCH v6 3/5] 9pfs: add new function v9fs_co_readdir_many()

2020-05-04 Thread Greg Kurz
On Fri, 01 May 2020 16:04:41 +0200 Christian Schoenebeck wrote: > On Donnerstag, 30. April 2020 15:30:49 CEST Greg Kurz wrote: > > > > I agree that a client that issues concurrent readdir requests on the > > > > same fid is probably asking for troubles, but this permitted by the > > > > spec.

Re: [PATCH v6 3/5] 9pfs: add new function v9fs_co_readdir_many()

2020-05-01 Thread Christian Schoenebeck
On Donnerstag, 30. April 2020 15:30:49 CEST Greg Kurz wrote: > > > I agree that a client that issues concurrent readdir requests on the > > > same fid is probably asking for troubles, but this permitted by the > > > spec. Whether we should detect such conditions and warn or even fail > > > is

Re: [PATCH v6 3/5] 9pfs: add new function v9fs_co_readdir_many()

2020-04-30 Thread Greg Kurz
On Thu, 30 Apr 2020 14:50:31 +0200 Christian Schoenebeck wrote: > On Donnerstag, 30. April 2020 13:42:35 CEST Greg Kurz wrote: > > > +/* > > > + * This is solely executed on a background IO thread. > > > + * > > > + * See v9fs_co_readdir_many() (as its only user) below for details. > > > + */ >

Re: [PATCH v6 3/5] 9pfs: add new function v9fs_co_readdir_many()

2020-04-30 Thread Christian Schoenebeck
On Donnerstag, 30. April 2020 13:42:35 CEST Greg Kurz wrote: > > +/* > > + * This is solely executed on a background IO thread. > > + * > > + * See v9fs_co_readdir_many() (as its only user) below for details. > > + */ > > +static int do_readdir_many(V9fsPDU *pdu, V9fsFidState *fidp, > > +

Re: [PATCH v6 3/5] 9pfs: add new function v9fs_co_readdir_many()

2020-04-30 Thread Greg Kurz
On Sun, 19 Apr 2020 17:02:27 +0200 Christian Schoenebeck wrote: > The newly added function v9fs_co_readdir_many() retrieves multiple > directory entries with a single fs driver request. It is intended to > replace uses of v9fs_co_readdir(), the latter only retrives a single > directory entry per

[PATCH v6 3/5] 9pfs: add new function v9fs_co_readdir_many()

2020-04-19 Thread Christian Schoenebeck
The newly added function v9fs_co_readdir_many() retrieves multiple directory entries with a single fs driver request. It is intended to replace uses of v9fs_co_readdir(), the latter only retrives a single directory entry per fs driver request instead. The reason for this planned replacement is