Re: [PATCH v6 3/9] qdev: add clock input support to devices.

2019-12-04 Thread Damien Hedde
On 12/4/19 10:53 AM, Philippe Mathieu-Daudé wrote: > On 12/4/19 10:05 AM, Damien Hedde wrote: >> On 12/2/19 3:34 PM, Peter Maydell wrote: >>> On Wed, 4 Sep 2019 at 13:56, Damien Hedde >>> wrote: > [...] +/** + * qdev_pass_clock: + * @dev: the device to forward the clock to

Re: [PATCH v6 3/9] qdev: add clock input support to devices.

2019-12-04 Thread Philippe Mathieu-Daudé
On 12/4/19 10:05 AM, Damien Hedde wrote: On 12/2/19 3:34 PM, Peter Maydell wrote: On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote: [...] +/** + * qdev_pass_clock: + * @dev: the device to forward the clock to + * @name: the name of the clock to be added (can't be NULL) + * @container: the

Re: [PATCH v6 3/9] qdev: add clock input support to devices.

2019-12-04 Thread Damien Hedde
On 12/2/19 3:34 PM, Peter Maydell wrote: > On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote: >> >> Add functions to easily add input or output clocks to a device. >> A clock objects is added as a child of the device. > > "object" > >> The api is very similar the gpio's one. > > "API"; "to

Re: [PATCH v6 3/9] qdev: add clock input support to devices.

2019-12-03 Thread Damien Hedde
On 11/25/19 2:30 PM, Philippe Mathieu-Daudé wrote: > Nitpick: remove trailing dot in patch subject > > On 9/4/19 2:55 PM, Damien Hedde wrote: >> Add functions to easily add input or output clocks to a device. >> A clock objects is added as a child of the device. > > ? > >> The api is very

Re: [PATCH v6 3/9] qdev: add clock input support to devices.

2019-12-02 Thread Peter Maydell
On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote: > > Add functions to easily add input or output clocks to a device. > A clock objects is added as a child of the device. "object" > The api is very similar the gpio's one. "API"; "to the GPIO API". > > This is based on the original work of

Re: [PATCH v6 3/9] qdev: add clock input support to devices.

2019-11-25 Thread Philippe Mathieu-Daudé
Nitpick: remove trailing dot in patch subject On 9/4/19 2:55 PM, Damien Hedde wrote: Add functions to easily add input or output clocks to a device. A clock objects is added as a child of the device. ? The api is very similar the gpio's one. Maybe "This API is very similar to the QDEV

[Qemu-devel] [PATCH v6 3/9] qdev: add clock input support to devices.

2019-09-04 Thread Damien Hedde
Add functions to easily add input or output clocks to a device. A clock objects is added as a child of the device. The api is very similar the gpio's one. This is based on the original work of Frederic Konrad. Signed-off-by: Damien Hedde --- I've removed the reviewed-by/tested-by of Philippe

[Qemu-devel] [PATCH v6 3/9] qdev: add clock input support to devices.

2019-09-04 Thread damien . hedde
From: Damien Hedde Add functions to easily add input or output clocks to a device. A clock objects is added as a child of the device. The api is very similar the gpio's one. This is based on the original work of Frederic Konrad. Signed-off-by: Damien Hedde --- I've removed the