Re: [RESEND PATCH v6 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-03-14 Thread Jonathan Cameron via
> > diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h > > index 7e5ad65c1d..d589f78202 100644 > > --- a/include/hw/cxl/cxl_device.h > > +++ b/include/hw/cxl/cxl_device.h > > @@ -232,6 +232,14 @@ REG64(CXL_MEM_DEV_STS, 0) > > FIELD(CXL_MEM_DEV_STS, MBOX_READY, 4, 1) > >

Re: [RESEND PATCH v6 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-03-07 Thread Michael S. Tsirkin
On Tue, Mar 07, 2023 at 07:26:41PM +, Fan Ni wrote: > > +typedef struct CXLError { > > +QTAILQ_ENTRY(CXLError) node; > > +int type; /* Error code as per FE definition */ > > +uint32_t header[32]; > Instead of using 32 here, would it be better to use > CXL_RAS_ERR_HEADER_NUM?

Re: [RESEND PATCH v6 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-03-07 Thread Fan Ni
On Thu, Mar 02, 2023 at 01:37:09PM +, Jonathan Cameron wrote: > CXL uses PCI AER Internal errors to signal to the host that an error has > occurred. The host can then read more detailed status from the CXL RAS > capability. > > For uncorrectable errors: support multiple injection in one

Re: [RESEND PATCH v6 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-03-07 Thread Michael S. Tsirkin
On Thu, Mar 02, 2023 at 01:37:09PM +, Jonathan Cameron wrote: > CXL uses PCI AER Internal errors to signal to the host that an error has > occurred. The host can then read more detailed status from the CXL RAS > capability. > > For uncorrectable errors: support multiple injection in one

Re: [PATCH v6 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-03-02 Thread Jonathan Cameron via
On Thu, 2 Mar 2023 05:55:00 -0500 "Michael S. Tsirkin" wrote: > On Thu, Mar 02, 2023 at 11:49:52AM +0100, Philippe Mathieu-Daudé wrote: > > On 2/3/23 11:06, Jonathan Cameron wrote: > > > +CC Michael Roth. > > > > > > Michael Tsirkin noted I'd missed CCing QAPI maintaintainers on the > > >

[RESEND PATCH v6 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-03-02 Thread Jonathan Cameron via
CXL uses PCI AER Internal errors to signal to the host that an error has occurred. The host can then read more detailed status from the CXL RAS capability. For uncorrectable errors: support multiple injection in one operation as this is needed to reliably test multiple header logging support in

Re: [PATCH v6 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-03-02 Thread Michael S. Tsirkin
On Thu, Mar 02, 2023 at 11:49:52AM +0100, Philippe Mathieu-Daudé wrote: > On 2/3/23 11:06, Jonathan Cameron wrote: > > +CC Michael Roth. > > > > Michael Tsirkin noted I'd missed CCing QAPI maintaintainers on the > > poison injection series so I went back to check the others I had out for > >

Re: [PATCH v6 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-03-02 Thread Philippe Mathieu-Daudé
On 2/3/23 11:06, Jonathan Cameron wrote: +CC Michael Roth. Michael Tsirkin noted I'd missed CCing QAPI maintaintainers on the poison injection series so I went back to check the others I had out for review. For this series I'd managed to pick up one of two as Markus gave comments on earlier

Re: [PATCH v6 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-03-02 Thread Jonathan Cameron via
+CC Michael Roth. Michael Tsirkin noted I'd missed CCing QAPI maintaintainers on the poison injection series so I went back to check the others I had out for review. For this series I'd managed to pick up one of two as Markus gave comments on earlier versions. On Mon, 27 Feb 2023 11:27:51 +

[PATCH v6 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-02-27 Thread Jonathan Cameron via
CXL uses PCI AER Internal errors to signal to the host that an error has occurred. The host can then read more detailed status from the CXL RAS capability. For uncorrectable errors: support multiple injection in one operation as this is needed to reliably test multiple header logging support in