Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-14 Thread Christian Schoenebeck
On Monday, March 13, 2023 8:06:15 PM CET Dorinda Bassey wrote: > > > > Are you sure about sizeof(n_bytes) here? That's 4. ;-) > > > my bad! > > > > > Volker's point was that "silence" is the center of the wave range. With > > signed > > range that's zero, yes, but with unsigned range that's

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-13 Thread Volker Rümelin
Am 13.03.23 um 14:11 schrieb Dorinda Bassey: Hi Volker, To hear this, start QEMU with qemu-system-x86_64 -machine pcspk-audiodev=audio0 -device ich9-intel-hda -device hda-duplex,audiodev=audio0 -audiodev pipewire,id=audio0,out.mixing-engine=off ... I hear the clipped audio

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-13 Thread Dorinda Bassey
> > Are you sure about sizeof(n_bytes) here? That's 4. ;-) > my bad! > > Volker's point was that "silence" is the center of the wave range. With > signed > range that's zero, yes, but with unsigned range that's 2^(bitdepth) / 2. > > So you need to memset() the correct value to generate "silence".

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-13 Thread Christian Schoenebeck
On Monday, March 13, 2023 2:11:11 PM CET Dorinda Bassey wrote: > Hi Volker, > > > > To hear this, > > start QEMU with qemu-system-x86_64 -machine pcspk-audiodev=audio0 > > -device ich9-intel-hda -device hda-duplex,audiodev=audio0 -audiodev > > pipewire,id=audio0,out.mixing-engine=off ... > > > I

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-13 Thread Dorinda Bassey
Hi Volker, > To hear this, > start QEMU with qemu-system-x86_64 -machine pcspk-audiodev=audio0 > -device ich9-intel-hda -device hda-duplex,audiodev=audio0 -audiodev > pipewire,id=audio0,out.mixing-engine=off ... > I hear the clipped audio stream with these options. IMO, I don't think memset is

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-12 Thread Volker Rümelin
+/* output data processing function to read stuffs from the buffer */ +static void +playback_on_process(void *data) +{ +PWVoice *v = (PWVoice *) data; +void *p; +struct pw_buffer *b; +struct spa_buffer *buf; +uint32_t n_frames, req, index, n_bytes; +int32_t avail; + +

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-09 Thread Volker Rümelin
Hi Dorinda, I've started to write down my suggestions and comments. After more than one page of text, I think that without sample code, the text is not very understandable. Therefore I will write three mails. In this mail I describe the problem with the QEMU Pipewire audio backend. My next

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-09 Thread Dorinda Bassey
Hi Marc-André, Thank you for your feedback. Given that we have only one loop, I would set the thread name to NULL, > (which will use "pw-thread-loop" by default) > I think it's preferable to be explicit and clear about the thread name. It's not clear to me the reason being that it's only one

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-08 Thread Volker Rümelin
Am 08.03.23 um 11:39 schrieb Marc-André Lureau: Volker, Wim, it would be nice if you could review/comment too! thanks Hi, last weekend I replaced pulseaudio with pipewire on my host computer and tested the QEMU pipewire backend. It doesn't work well on my computer, but with a few changes

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-08 Thread Marc-André Lureau
Hi On Mon, Mar 6, 2023 at 9:11 PM Dorinda Bassey wrote: > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as > both an audio sink and source. This backend is available on most systems > > Add Pipewire entry points for QEMU Pipewire audio backend > Add wrappers for QEMU

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-07 Thread Dorinda Bassey
Hi Marc-André, Do you mind summarizing your review on the buffering section, and leave comments so i can address everything once and for all? This will help reduce the number of versions that needs to be done. Thanks, Dorinda. On Tue, Mar 7, 2023 at 3:41 PM Marc-André Lureau wrote: > Hi

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-07 Thread Marc-André Lureau
Hi Dorinda On Mon, Mar 6, 2023 at 9:11 PM Dorinda Bassey wrote: > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as > both an audio sink and source. This backend is available on most systems > > Add Pipewire entry points for QEMU Pipewire audio backend > Add wrappers for

[PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-06 Thread Dorinda Bassey
This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. This backend is available on most systems Add Pipewire entry points for QEMU Pipewire audio backend Add wrappers for QEMU Pipewire audio backend in qpw_pcm_ops() qpw_write function returns the