Re: [PATCH v7 01/14] block: return status from bdrv_append and friends

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
05.02.2021 14:16, Alberto Garcia wrote: On Tue 02 Feb 2021 01:49:43 PM CET, Vladimir Sementsov-Ogievskiy wrote: The recommended use of qemu error api assumes returning status together with setting errp and avoid void functions with errp parameter. Let's improve bdrv_append and some friends to

Re: [PATCH v7 01/14] block: return status from bdrv_append and friends

2021-02-05 Thread Alberto Garcia
On Tue 02 Feb 2021 01:49:43 PM CET, Vladimir Sementsov-Ogievskiy wrote: > The recommended use of qemu error api assumes returning status together > with setting errp and avoid void functions with errp parameter. Let's > improve bdrv_append and some friends to reduce error-propagation > overhead in

[PATCH v7 01/14] block: return status from bdrv_append and friends

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
The recommended use of qemu error api assumes returning status together with setting errp and avoid void functions with errp parameter. Let's improve bdrv_append and some friends to reduce error-propagation overhead in further patches. Choose int return status, because bdrv_replace_node_common()