On Thu, 23 Feb 2023 16:10:59 PST (-0800), Richard Henderson wrote:
On 2/23/23 13:44, Daniel Henrique Barboza wrote:
probe_access_flags() as it is today uses probe_access_full(), which in
turn uses probe_access_internal() with size = 0. probe_access_internal()
then uses the size to call the
On 2/23/23 21:23, Richard Henderson wrote:
On 2/23/23 14:19, Richard Henderson wrote:
On 2/23/23 13:44, Daniel Henrique Barboza wrote:
+ if (unlikely(flags & TLB_NOTDIRTY)) {
+ notdirty_write(env_cpu(env), addr, 1, full, retaddr);
That '1' should be 'size'. Fixed locally.
On 2/23/23 14:19, Richard Henderson wrote:
On 2/23/23 13:44, Daniel Henrique Barboza wrote:
+ if (unlikely(flags & TLB_NOTDIRTY)) {
+ notdirty_write(env_cpu(env), addr, 1, full, retaddr);
That '1' should be 'size'. Fixed locally.
Hmph, well, that matches the interface, but it's
On 2/23/23 13:44, Daniel Henrique Barboza wrote:
+if (unlikely(flags & TLB_NOTDIRTY)) {
+notdirty_write(env_cpu(env), addr, 1, full, retaddr);
That '1' should be 'size'. Fixed locally.
r~
On 2/23/23 13:44, Daniel Henrique Barboza wrote:
probe_access_flags() as it is today uses probe_access_full(), which in
turn uses probe_access_internal() with size = 0. probe_access_internal()
then uses the size to call the tlb_fill() callback for the given CPU.
This size param ('fault_size' as
On 2/23/23 13:44, Daniel Henrique Barboza wrote:
probe_access_flags() as it is today uses probe_access_full(), which in
turn uses probe_access_internal() with size = 0. probe_access_internal()
then uses the size to call the tlb_fill() callback for the given CPU.
This size param ('fault_size' as
probe_access_flags() as it is today uses probe_access_full(), which in
turn uses probe_access_internal() with size = 0. probe_access_internal()
then uses the size to call the tlb_fill() callback for the given CPU.
This size param ('fault_size' as probe_access_internal() calls it) is
ignored by
