On Wed, 6 Mar 2024 10:33:17 +
Ankit Agrawal wrote:
> >> >> Jonathan, Alex, do you know how we may add tests that is dependent
> >> >> on the vfio-pci device?
> >> >
> >> > There are none.
> >> >
> >> > This would require a host device always available for passthrough and
> >> > there is no
>> > The structure needs a PCI device handle [2] that consists of the device
>> > BDF.
>> > The vfio-pci device corresponding to the acpi-generic-initiator object is
>> > located to determine the BDF.
>> >
>> > [1] ACPI Spec 6.3, Section 5.2.16.6
>> > [2] ACPI Spec 6.3, Table 5.80
>> >
>> >
>>
>> Jonathan, Alex, do you know how we may add tests that is dependent
>> on the vfio-pci device?
>>
>
> As Jonathan notes, we've decoupled this from vfio-pci, the pci-dev= arg
> can point to any PCI device. For example, any emulated PCI NIC could
> be a stand-in for the vfio-pci device used in
>> >> Jonathan, Alex, do you know how we may add tests that is dependent
>> >> on the vfio-pci device?
>> >
>> > There are none.
>> >
>> > This would require a host device always available for passthrough and
>> > there is no simple solution for this problem. Such tests would need to
>> > run in a
On Mon, 26 Feb 2024 16:42:29 +
Jonathan Cameron via wrote:
> On Fri, 23 Feb 2024 12:42:23 +
> wrote:
>
> > From: Ankit Agrawal
> >
> > ACPI spec provides a scheme to associate "Generic Initiators" [1]
> > (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with
> >
On Tue, 5 Mar 2024 05:59:46 +
Ankit Agrawal wrote:
> > One thing I forgot.
> >
> > Please add a test. tests/qtest/bios-tables-test.c
> > + relevant table dumps.
>
> Here I need to add a test that creates a vfio-pci device and numa
> nodes and link using the acpi-generic-initiator object.
On Tue, 5 Mar 2024 08:17:18 +
Ankit Agrawal wrote:
> >>> Please add a test. tests/qtest/bios-tables-test.c
> >>> + relevant table dumps.
> >>
> >> Here I need to add a test that creates a vfio-pci device and numa
> >> nodes and link using the acpi-generic-initiator object. One thing
> >>
>>> Please add a test. tests/qtest/bios-tables-test.c
>>> + relevant table dumps.
>>
>> Here I need to add a test that creates a vfio-pci device and numa
>> nodes and link using the acpi-generic-initiator object. One thing
>> here is that the -device vfio-pci needs a host= argument. I
>>
On 3/5/24 06:59, Ankit Agrawal wrote:
One thing I forgot.
Please add a test. tests/qtest/bios-tables-test.c
+ relevant table dumps.
Here I need to add a test that creates a vfio-pci device and numa
nodes and link using the acpi-generic-initiator object. One thing
here is that the -device
> One thing I forgot.
>
> Please add a test. tests/qtest/bios-tables-test.c
> + relevant table dumps.
Here I need to add a test that creates a vfio-pci device and numa
nodes and link using the acpi-generic-initiator object. One thing
here is that the -device vfio-pci needs a host= argument. I
>>
>> One more thing. Right now we can't use Generic Initiators as
>> HMAT initiators. That also wants fixing given that's their
>> normal usecase rather than what you are using them for so it
>> should 'work'.
>
> Something along the lines of this will do the job.
Thanks! Will incorporate the
On Tue, 27 Feb 2024 17:36:21 +
Jonathan Cameron wrote:
> On Tue, 27 Feb 2024 17:11:15 +
> Jonathan Cameron via wrote:
>
> > On Tue, 27 Feb 2024 08:37:15 +
> > Ankit Agrawal wrote:
> >
> > > Thanks Jonathan for reviewing the change.
> > >
> > > Comments inline.
> > >
> > >
>> > One thing I forgot.
>> >
>> > Please add a test. tests/qtest/bios-tables-test.c
>>
>> IIUC, we need to add a test for aarch64 to test the interface with the
>> acpi-generic-initiator object.
>>
>> > + relevant table dumps.
>>
>> Sorry it isn't clear where do you want me to add this. In the
On Thu, 29 Feb 2024 11:46:27 +
Ankit Agrawal wrote:
> >> ---
> >> hw/acpi/acpi-generic-initiator.c | 84
> >> hw/arm/virt-acpi-build.c | 3 +
> >> include/hw/acpi/acpi-generic-initiator.h | 26
> > A few more comments.
> >
> >
On Thu, 29 Feb 2024 11:43:44 +
Ankit Agrawal wrote:
> > One thing I forgot.
> >
> > Please add a test. tests/qtest/bios-tables-test.c
>
> IIUC, we need to add a test for aarch64 to test the interface with the
> acpi-generic-initiator object.
>
> > + relevant table dumps.
>
> Sorry it
>> ---
>> hw/acpi/acpi-generic-initiator.c | 84
>> hw/arm/virt-acpi-build.c | 3 +
>> include/hw/acpi/acpi-generic-initiator.h | 26
> A few more comments.
>
> Maybe _ rather than - as more common for acpi include naming.
Ack. will
> One thing I forgot.
>
> Please add a test. tests/qtest/bios-tables-test.c
IIUC, we need to add a test for aarch64 to test the interface with the
acpi-generic-initiator object.
> + relevant table dumps.
Sorry it isn't clear where do you want me to add this. In the git commit
message?
On Tue, 27 Feb 2024 17:11:15 +
Jonathan Cameron via wrote:
> On Tue, 27 Feb 2024 08:37:15 +
> Ankit Agrawal wrote:
>
> > Thanks Jonathan for reviewing the change.
> >
> > Comments inline.
> >
> > >> The structure needs a PCI device handle [2] that consists of the device
> > >>
On Tue, 27 Feb 2024 08:37:15 +
Ankit Agrawal wrote:
> Thanks Jonathan for reviewing the change.
>
> Comments inline.
>
> >> The structure needs a PCI device handle [2] that consists of the device
> >> BDF.
> >> The vfio-pci device corresponding to the acpi-generic-initiator object is
> >>
On Fri, 23 Feb 2024 12:42:23 +
wrote:
> From: Ankit Agrawal
>
> ACPI spec provides a scheme to associate "Generic Initiators" [1]
> (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with
> integrated compute or DMA engines GPUs) with Proximity Domains. This is
>
Thanks Jonathan for reviewing the change.
Comments inline.
>> The structure needs a PCI device handle [2] that consists of the device BDF.
>> The vfio-pci device corresponding to the acpi-generic-initiator object is
>> located to determine the BDF.
>>
>> [1] ACPI Spec 6.3, Section 5.2.16.6
>>
On Fri, 23 Feb 2024 12:42:23 +
wrote:
> From: Ankit Agrawal
>
> ACPI spec provides a scheme to associate "Generic Initiators" [1]
> (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with
> integrated compute or DMA engines GPUs) with Proximity Domains. This is
>
On Fri, 23 Feb 2024 12:42:23 +
wrote:
> From: Ankit Agrawal
>
> ACPI spec provides a scheme to associate "Generic Initiators" [1]
> (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with
> integrated compute or DMA engines GPUs) with Proximity Domains. This is
>
From: Ankit Agrawal
ACPI spec provides a scheme to associate "Generic Initiators" [1]
(e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with
integrated compute or DMA engines GPUs) with Proximity Domains. This is
achieved using Generic Initiator Affinity Structure in SRAT.
24 matches
Mail list logo
