Re: [PATCH v8 09/11] block: check availablity for preadv/pwritev on mac

2021-01-23 Thread Joelle van Dyne
Sorry to rephrase this, we would like a single binary to work on both macOS 10.15 and macOS 11 as well as on both iOS 13 and iOS 14 while ALSO supporting preadv/pwritev when running on the newer OS. -j On Sat, Jan 23, 2021 at 12:00 PM Joelle van Dyne wrote: > > The problem here is that we would

Re: [PATCH v8 09/11] block: check availablity for preadv/pwritev on mac

2021-01-23 Thread Joelle van Dyne
The problem here is that we would like to compile on macOS 11 and be able to run the built binaries on macOS 10.15 or lower. Without the runtime checks, you'll have a crash when calling preadv/pwritev. -j On Sat, Jan 23, 2021 at 5:53 AM Peter Maydell wrote: > > On Sat, 23 Jan 2021 at 05:03,

Re: [PATCH v8 09/11] block: check availablity for preadv/pwritev on mac

2021-01-23 Thread Peter Maydell
On Sat, 23 Jan 2021 at 05:03, Joelle van Dyne wrote: > > macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure > will succeed with CONFIG_PREADV even when targeting a lower OS version. > We therefore need to check at run time if we can actually use these APIs. If you make the

[PATCH v8 09/11] block: check availablity for preadv/pwritev on mac

2021-01-22 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 33