Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread Thomas Huth
On 23/09/2022 14.07, Jason A. Donenfeld wrote: On Fri, Sep 23, 2022 at 2:05 PM Thomas Huth wrote: On 23/09/2022 13.46, Jason A. Donenfeld wrote: Hi David, On Fri, Sep 23, 2022 at 1:35 PM David Hildenbrand wrote: On 23.09.22 13:19, Jason A. Donenfeld wrote: On Fri, Sep 23, 2022 at 12:47

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread Thomas Huth
On 23/09/2022 13.46, Jason A. Donenfeld wrote: Hi David, On Fri, Sep 23, 2022 at 1:35 PM David Hildenbrand wrote: On 23.09.22 13:19, Jason A. Donenfeld wrote: On Fri, Sep 23, 2022 at 12:47 PM David Hildenbrand wrote: You must be fortunate if "one afternoon" is not a significant time

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread Jason A. Donenfeld
On Fri, Sep 23, 2022 at 2:05 PM Thomas Huth wrote: > > On 23/09/2022 13.46, Jason A. Donenfeld wrote: > > Hi David, > > > > On Fri, Sep 23, 2022 at 1:35 PM David Hildenbrand wrote: > >> > >> On 23.09.22 13:19, Jason A. Donenfeld wrote: > >>> On Fri, Sep 23, 2022 at 12:47 PM David Hildenbrand >

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread David Hildenbrand
On 23.09.22 13:46, Jason A. Donenfeld wrote: Hi David, On Fri, Sep 23, 2022 at 1:35 PM David Hildenbrand wrote: On 23.09.22 13:19, Jason A. Donenfeld wrote: On Fri, Sep 23, 2022 at 12:47 PM David Hildenbrand wrote: You must be fortunate if "one afternoon" is not a significant time

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread Jason A. Donenfeld
Hi David, On Fri, Sep 23, 2022 at 1:35 PM David Hildenbrand wrote: > > On 23.09.22 13:19, Jason A. Donenfeld wrote: > > On Fri, Sep 23, 2022 at 12:47 PM David Hildenbrand wrote: > >> You must be fortunate if "one afternoon" is not a significant time > >> investment. For me it is a significant

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread David Hildenbrand
On 23.09.22 13:19, Jason A. Donenfeld wrote: On Fri, Sep 23, 2022 at 12:47 PM David Hildenbrand wrote: You must be fortunate if "one afternoon" is not a significant time investment. For me it is a significant investment. For me too, to say the least of the multiple afternoons I've spent on

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread Jason A. Donenfeld
On Fri, Sep 23, 2022 at 12:47 PM David Hildenbrand wrote: > You must be fortunate if "one afternoon" is not a significant time > investment. For me it is a significant investment. For me too, to say the least of the multiple afternoons I've spent on this patch set. Getting back to technical

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread David Hildenbrand
3) I won't follow up with additional cleanup patches because I already spent more time on this than I originally planned. What is this B.S.? I spent months on this code and had to poke you a bunch to review it. You spend one afternoon with it and you're already burnt out, apparently. Sorry to

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread Jason A. Donenfeld
Hi David & Thomas, On Fri, Sep 23, 2022 at 08:37:50AM +0200, David Hildenbrand wrote: > > But the point is that the "msa" helper is also called for other instructions > > like PCKMO which can also be called with code 3. And there it means > > something completely different. ... unless I

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread David Hildenbrand
On 23.09.22 08:23, Thomas Huth wrote: On 22/09/2022 19.18, David Hildenbrand wrote: On 22.09.22 17:55, Thomas Huth wrote: On 22/09/2022 17.38, David Hildenbrand wrote: From: "Jason A. Donenfeld" In order to fully support MSA_EXT_5, we have to support the SHA-512 special instructions. So

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread Thomas Huth
On 22/09/2022 18.35, Jason A. Donenfeld wrote: On Thu, Sep 22, 2022 at 5:55 PM Thomas Huth wrote: On 22/09/2022 17.38, David Hildenbrand wrote: From: "Jason A. Donenfeld" In order to fully support MSA_EXT_5, we have to support the SHA-512 special instructions. So implement those. The

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread Thomas Huth
On 22/09/2022 19.18, David Hildenbrand wrote: On 22.09.22 17:55, Thomas Huth wrote: On 22/09/2022 17.38, David Hildenbrand wrote: From: "Jason A. Donenfeld" In order to fully support MSA_EXT_5, we have to support the SHA-512 special instructions. So implement those. The implementation began

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-22 Thread David Hildenbrand
On 22.09.22 17:55, Thomas Huth wrote: On 22/09/2022 17.38, David Hildenbrand wrote: From: "Jason A. Donenfeld" In order to fully support MSA_EXT_5, we have to support the SHA-512 special instructions. So implement those. The implementation began as something TweetNacl-like, and then was

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-22 Thread Jason A. Donenfeld
On Thu, Sep 22, 2022 at 5:55 PM Thomas Huth wrote: > > On 22/09/2022 17.38, David Hildenbrand wrote: > > From: "Jason A. Donenfeld" > > > > In order to fully support MSA_EXT_5, we have to support the SHA-512 > > special instructions. So implement those. > > > > The implementation began as

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-22 Thread Thomas Huth
On 22/09/2022 17.38, David Hildenbrand wrote: From: "Jason A. Donenfeld" In order to fully support MSA_EXT_5, we have to support the SHA-512 special instructions. So implement those. The implementation began as something TweetNacl-like, and then was adjusted to be useful here. It's not very

[PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-22 Thread David Hildenbrand
From: "Jason A. Donenfeld" In order to fully support MSA_EXT_5, we have to support the SHA-512 special instructions. So implement those. The implementation began as something TweetNacl-like, and then was adjusted to be useful here. It's not very beautiful, but it is quite short and compact,