Re: [PATCH v9 02/11] migration: Make save_snapshot() return bool, not 0/-1

2021-01-25 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > From: Philippe Mathieu-Daudé > > Just for consistency, following the example documented since > commit e3fe3988d7 ("error: Document Error API usage rules"), > return a boolean value indicating an error is set or not. > > Acked-by: Pavel

Re: [PATCH v9 02/11] migration: Make save_snapshot() return bool, not 0/-1

2021-01-20 Thread Eric Blake
On 1/20/21 12:46 PM, Eric Blake wrote: > On 1/20/21 4:44 AM, Daniel P. Berrangé wrote: >> From: Philippe Mathieu-Daudé >> >> Just for consistency, following the example documented since >> commit e3fe3988d7 ("error: Document Error API usage rules"), >> return a boolean value indicating an error

Re: [PATCH v9 02/11] migration: Make save_snapshot() return bool, not 0/-1

2021-01-20 Thread Eric Blake
On 1/20/21 4:44 AM, Daniel P. Berrangé wrote: > From: Philippe Mathieu-Daudé > > Just for consistency, following the example documented since > commit e3fe3988d7 ("error: Document Error API usage rules"), > return a boolean value indicating an error is set or not. > > Acked-by: Pavel Dovgalyuk

[PATCH v9 02/11] migration: Make save_snapshot() return bool, not 0/-1

2021-01-20 Thread Daniel P . Berrangé
From: Philippe Mathieu-Daudé Just for consistency, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), return a boolean value indicating an error is set or not. Acked-by: Pavel Dovgalyuk Signed-off-by: Philippe Mathieu-Daudé ---