Re: [PATCH v9 08/21] jobs: add job lock in find_* functions

2022-07-11 Thread Vladimir Sementsov-Ogievskiy
On 7/6/22 23:15, Emanuele Giuseppe Esposito wrote: Both blockdev.c and job-qmp.c have TOC/TOU conditions, because they first search for the job and then perform an action on it. Therefore, we need to do the search + action under the same job mutex critical section. Note: at this stage,

[PATCH v9 08/21] jobs: add job lock in find_* functions

2022-07-06 Thread Emanuele Giuseppe Esposito
Both blockdev.c and job-qmp.c have TOC/TOU conditions, because they first search for the job and then perform an action on it. Therefore, we need to do the search + action under the same job mutex critical section. Note: at this stage, job_{lock/unlock} and job lock guard macros are *nop*.