Re: [PATCH v9 09/11] virtio-gpu: Register capsets dynamically

2024-05-03 Thread Akihiko Odaki
On 2024/05/02 4:52, Dmitry Osipenko wrote: On 5/1/24 22:38, Dmitry Osipenko wrote: On 5/1/24 22:31, Dmitry Osipenko wrote: On 4/27/24 10:12, Akihiko Odaki wrote:   int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g)   {   uint32_t capset2_max_ver, capset2_max_size; + +    if

Re: [PATCH v9 09/11] virtio-gpu: Register capsets dynamically

2024-05-01 Thread Dmitry Osipenko
On 5/1/24 22:38, Dmitry Osipenko wrote: > On 5/1/24 22:31, Dmitry Osipenko wrote: >> On 4/27/24 10:12, Akihiko Odaki wrote:   int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g)   {   uint32_t capset2_max_ver, capset2_max_size; + +    if (g->capset_ids) { >>> >>> Move

Re: [PATCH v9 09/11] virtio-gpu: Register capsets dynamically

2024-05-01 Thread Dmitry Osipenko
On 5/1/24 22:31, Dmitry Osipenko wrote: > On 4/27/24 10:12, Akihiko Odaki wrote: >>>   int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g) >>>   { >>>   uint32_t capset2_max_ver, capset2_max_size; >>> + >>> +    if (g->capset_ids) { >> >> Move capset_ids initialization to

Re: [PATCH v9 09/11] virtio-gpu: Register capsets dynamically

2024-05-01 Thread Dmitry Osipenko
On 4/27/24 10:12, Akihiko Odaki wrote: >>   int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g) >>   { >>   uint32_t capset2_max_ver, capset2_max_size; >> + >> +    if (g->capset_ids) { > > Move capset_ids initialization to virtio_gpu_virgl_init() to save this > conditional. Capsets are used

Re: [PATCH v9 09/11] virtio-gpu: Register capsets dynamically

2024-04-27 Thread Akihiko Odaki
On 2024/04/26 0:45, Dmitry Osipenko wrote: From: Pierre-Eric Pelloux-Prayer virtio_gpu_virgl_get_num_capsets will return "num_capsets", but we can't assume that capset_index 1 is always VIRGL2 once we'll support more capsets, like Venus and DRM capsets. Register capsets dynamically to avoid

[PATCH v9 09/11] virtio-gpu: Register capsets dynamically

2024-04-25 Thread Dmitry Osipenko
From: Pierre-Eric Pelloux-Prayer virtio_gpu_virgl_get_num_capsets will return "num_capsets", but we can't assume that capset_index 1 is always VIRGL2 once we'll support more capsets, like Venus and DRM capsets. Register capsets dynamically to avoid that problem. Signed-off-by: Pierre-Eric