Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-14 Thread Maxim Uvarov
On Thu, 14 Jan 2021 at 14:48, Peter Maydell wrote: > > On Thu, 14 Jan 2021 at 11:24, Maxim Uvarov wrote: > > > > On Thu, 14 Jan 2021 at 14:22, Maxim Uvarov wrote: > > > Does that mean that in that case you need all regions to be 64k > > > aligned? I mean secure and non-secure. > > > Has anybody

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-14 Thread Peter Maydell
On Thu, 14 Jan 2021 at 11:24, Maxim Uvarov wrote: > > On Thu, 14 Jan 2021 at 14:22, Maxim Uvarov wrote: > > Does that mean that in that case you need all regions to be 64k > > aligned? I mean secure and non-secure. > > Has anybody tested 64k pages under qemu? > > [VIRT_GIC_V2M] =

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-14 Thread Maxim Uvarov
On Thu, 14 Jan 2021 at 14:22, Maxim Uvarov wrote: > > On Thu, 14 Jan 2021 at 12:50, Peter Maydell wrote: > > > > On Thu, 14 Jan 2021 at 00:04, Andrew Jones wrote: > > > > > > On Wed, Jan 13, 2021 at 10:30:47AM +0300, Maxim Uvarov wrote: > > > > - the same size for secure and non secure gpio.

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-14 Thread Maxim Uvarov
On Thu, 14 Jan 2021 at 12:50, Peter Maydell wrote: > > On Thu, 14 Jan 2021 at 00:04, Andrew Jones wrote: > > > > On Wed, Jan 13, 2021 at 10:30:47AM +0300, Maxim Uvarov wrote: > > > - the same size for secure and non secure gpio. Arm doc says that > > > secure memory is also split on 4k pages. So

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-14 Thread Peter Maydell
On Thu, 14 Jan 2021 at 00:04, Andrew Jones wrote: > > On Wed, Jan 13, 2021 at 10:30:47AM +0300, Maxim Uvarov wrote: > > - the same size for secure and non secure gpio. Arm doc says that > > secure memory is also split on 4k pages. So one page here has to be > > ok. > > To be clear, does that

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-13 Thread Andrew Jones
On Wed, Jan 13, 2021 at 10:30:47AM +0300, Maxim Uvarov wrote: > - the same size for secure and non secure gpio. Arm doc says that > secure memory is also split on 4k pages. So one page here has to be > ok. To be clear, does that means 4k pages must be used? I'm not concerned with the size, but

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-12 Thread Maxim Uvarov
- the same size for secure and non secure gpio. Arm doc says that secure memory is also split on 4k pages. So one page here has to be ok. - will add dtb. - I think then less options is better. So I will remove vmc->secure_gpio flag and keep only vmc flag. Regards, Maxim. On Tue, 12 Jan 2021 at

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-12 Thread Andrew Jones
On Tue, Jan 12, 2021 at 11:25:30AM -0500, Andrew Jones wrote: > On Tue, Jan 12, 2021 at 04:00:23PM +, Peter Maydell wrote: > > On Tue, 12 Jan 2021 at 15:35, Andrew Jones wrote: > > > > > > On Tue, Jan 12, 2021 at 05:30:58PM +0300, Maxim Uvarov wrote: > > > > Add secure pl061 for reset/power

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-12 Thread Andrew Jones
On Tue, Jan 12, 2021 at 04:00:23PM +, Peter Maydell wrote: > On Tue, 12 Jan 2021 at 15:35, Andrew Jones wrote: > > > > On Tue, Jan 12, 2021 at 05:30:58PM +0300, Maxim Uvarov wrote: > > > Add secure pl061 for reset/power down machine from > > > the secure world (Arm Trusted Firmware). Connect

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-12 Thread Peter Maydell
On Tue, 12 Jan 2021 at 15:35, Andrew Jones wrote: > > On Tue, Jan 12, 2021 at 05:30:58PM +0300, Maxim Uvarov wrote: > > Add secure pl061 for reset/power down machine from > > the secure world (Arm Trusted Firmware). Connect it > > with gpio-pwr driver. > > +/* connect secure pl061 to

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-12 Thread Andrew Jones
On Tue, Jan 12, 2021 at 05:30:58PM +0300, Maxim Uvarov wrote: > Add secure pl061 for reset/power down machine from > the secure world (Arm Trusted Firmware). Connect it > with gpio-pwr driver. > > Signed-off-by: Maxim Uvarov > --- > hw/arm/Kconfig| 1 + > hw/arm/virt.c | 40

[PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-12 Thread Maxim Uvarov
Add secure pl061 for reset/power down machine from the secure world (Arm Trusted Firmware). Connect it with gpio-pwr driver. Signed-off-by: Maxim Uvarov --- hw/arm/Kconfig| 1 + hw/arm/virt.c | 40 include/hw/arm/virt.h | 3 +++ 3 files