Re: [PULL 18/28] file-posix: try BLKSECTGET on block devices too, do not round to power of 2

2021-09-23 Thread Paolo Bonzini
On 23/09/21 14:13, Halil Pasic wrote: On Thu, 23 Sep 2021 12:57:38 +0200 Paolo Bonzini wrote: On 22/09/21 21:51, Halil Pasic wrote: We have figured out what is going on here. The problem seems to be specific to linux aio, which seems to limit the size of the iovec to 1024 (UIO_MAXIOV). Hi H

Re: [PULL 18/28] file-posix: try BLKSECTGET on block devices too, do not round to power of 2

2021-09-23 Thread Halil Pasic
On Thu, 23 Sep 2021 12:57:38 +0200 Paolo Bonzini wrote: > On 22/09/21 21:51, Halil Pasic wrote: > > We have figured out what is going on here. The problem seems to be > > specific to linux aio, which seems to limit the size of the iovec to > > 1024 (UIO_MAXIOV). > > Hi Halil, > > I'll send a

Re: [PULL 18/28] file-posix: try BLKSECTGET on block devices too, do not round to power of 2

2021-09-23 Thread Paolo Bonzini
On 22/09/21 21:51, Halil Pasic wrote: We have figured out what is going on here. The problem seems to be specific to linux aio, which seems to limit the size of the iovec to 1024 (UIO_MAXIOV). Hi Halil, I'll send a patch shortly to fix this issue. Sorry about the delay as I was busy with KVM

Re: [PULL 18/28] file-posix: try BLKSECTGET on block devices too, do not round to power of 2

2021-09-22 Thread Halil Pasic
On Mon, 6 Sep 2021 16:24:20 +0200 Halil Pasic wrote: > On Fri, 25 Jun 2021 16:18:12 +0200 > Paolo Bonzini wrote: > > > bs->sg is only true for character devices, but block devices can also > > be used with scsi-block and scsi-generic. Unfortunately BLKSECTGET > > returns bytes in an int for /d

Re: [PULL 18/28] file-posix: try BLKSECTGET on block devices too, do not round to power of 2

2021-09-06 Thread Halil Pasic
On Fri, 25 Jun 2021 16:18:12 +0200 Paolo Bonzini wrote: > bs->sg is only true for character devices, but block devices can also > be used with scsi-block and scsi-generic. Unfortunately BLKSECTGET > returns bytes in an int for /dev/sgN devices, and sectors in a short > for block devices, so acco

[PULL 18/28] file-posix: try BLKSECTGET on block devices too, do not round to power of 2

2021-06-25 Thread Paolo Bonzini
bs->sg is only true for character devices, but block devices can also be used with scsi-block and scsi-generic. Unfortunately BLKSECTGET returns bytes in an int for /dev/sgN devices, and sectors in a short for block devices, so account for that in the code. The maximum transfer also need not be a