Re: [PULL 29/86] meson: move libudev test

2020-10-01 Thread Paolo Bonzini
On 01/10/20 20:51, Peter Maydell wrote: > Yes, I have a lot of --disable-foo options. Ideally I wouldn't > need any, because our configure/build system would identify "there > isn't actually a static version of this dependency present" > rather than blindly trusting pkg-config when it lies to us.

Re: [PULL 29/86] meson: move libudev test

2020-10-01 Thread Peter Maydell
On Thu, 1 Oct 2020 at 17:55, Paolo Bonzini wrote: > On 01/10/20 18:19, Peter Maydell wrote: > > I'm not very confident about reading meson.build logic, but it > > looks like this trusts meson/pkg-config to tell it about > > whether it can do a static link against this library, > > which doesn't

Re: [PULL 29/86] meson: move libudev test

2020-10-01 Thread Paolo Bonzini
On 01/10/20 18:19, Peter Maydell wrote: > Hi; this commit seems to have broken my static build. > Previously configure did not include libudev in the link > for a static build (there is no libudev.a, at least on my > system). Now it does, and then the link fails with > /usr/bin/ld: cannot find

Re: [PULL 29/86] meson: move libudev test

2020-10-01 Thread Peter Maydell
On Wed, 30 Sep 2020 at 21:01, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > --- > configure | 14 -- > meson.build | 7 --- > 2 files changed, 4 insertions(+), 17 deletions(-) Hi; this commit seems to have broken my static build. Previously configure did not

[PULL 29/86] meson: move libudev test

2020-09-30 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 14 -- meson.build | 7 --- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/configure b/configure index f9e2f3de65..6f2599f99f 100755 --- a/configure +++ b/configure @@ -908,7 +908,6 @@ Linux) linux_user="yes"