Re: [PULL v2 00/47] virtio,pc,pci: features, cleanups, fixes

2022-03-15 Thread Peter Maydell
On Tue, 15 Mar 2022 at 18:35, Philippe Mathieu-Daudé wrote: > On 8/3/22 12:18, Peter Maydell wrote: > > Using 'unsigned long' in a cast (or anything else) is often > > the wrong thing in QEMU... > > $ git grep -F '(unsigned long)' | wc -l > 273 > > Ouch :/ Only "often", not "always" :-) We

Re: [PULL v2 00/47] virtio,pc,pci: features, cleanups, fixes

2022-03-15 Thread Philippe Mathieu-Daudé
On 8/3/22 12:18, Peter Maydell wrote: On Tue, 8 Mar 2022 at 11:01, Michael S. Tsirkin wrote: On Tue, Mar 08, 2022 at 09:05:27AM +, Peter Maydell wrote: On Mon, 7 Mar 2022 at 22:52, Michael S. Tsirkin wrote: Now, I could maybe get behind this if it simply warned about a cast that loses

Re: [PULL v2 00/47] virtio,pc,pci: features, cleanups, fixes

2022-03-08 Thread Michael S. Tsirkin
On Tue, Mar 08, 2022 at 11:18:38AM +, Peter Maydell wrote: > On Tue, 8 Mar 2022 at 11:01, Michael S. Tsirkin wrote: > > > > On Tue, Mar 08, 2022 at 09:05:27AM +, Peter Maydell wrote: > > > On Mon, 7 Mar 2022 at 22:52, Michael S. Tsirkin wrote: > > > > > > > > On Mon, Mar 07, 2022 at 05:13

Re: [PULL v2 00/47] virtio,pc,pci: features, cleanups, fixes

2022-03-08 Thread Peter Maydell
On Tue, 8 Mar 2022 at 11:01, Michael S. Tsirkin wrote: > > On Tue, Mar 08, 2022 at 09:05:27AM +, Peter Maydell wrote: > > On Mon, 7 Mar 2022 at 22:52, Michael S. Tsirkin wrote: > > > > > > On Mon, Mar 07, 2022 at 05:13:16PM +, Peter Maydell wrote: > > > > Also fails on cross-win64-system:

Re: [PULL v2 00/47] virtio,pc,pci: features, cleanups, fixes

2022-03-08 Thread Michael S. Tsirkin
On Tue, Mar 08, 2022 at 09:05:27AM +, Peter Maydell wrote: > On Mon, 7 Mar 2022 at 22:52, Michael S. Tsirkin wrote: > > > > On Mon, Mar 07, 2022 at 05:13:16PM +, Peter Maydell wrote: > > > Also fails on cross-win64-system: > > > > > > https://gitlab.com/qemu-project/qemu/-/jobs/2172339938

Re: [PULL v2 00/47] virtio,pc,pci: features, cleanups, fixes

2022-03-08 Thread Peter Maydell
On Mon, 7 Mar 2022 at 22:52, Michael S. Tsirkin wrote: > > On Mon, Mar 07, 2022 at 05:13:16PM +, Peter Maydell wrote: > > Also fails on cross-win64-system: > > > > https://gitlab.com/qemu-project/qemu/-/jobs/2172339938 > > > > ../hw/virtio/virtio.c: In function 'qmp_x_query_virtio_vhost_queue_

Re: [PULL v2 00/47] virtio,pc,pci: features, cleanups, fixes

2022-03-07 Thread Michael S. Tsirkin
On Mon, Mar 07, 2022 at 05:13:16PM +, Peter Maydell wrote: > On Mon, 7 Mar 2022 at 17:06, Peter Maydell wrote: > > > > On Mon, 7 Mar 2022 at 10:01, Michael S. Tsirkin wrote: > > > > > > The following changes since commit > > > 6629bf78aac7e53f83fd0bcbdbe322e2302dfd1f: > > > > > > Merge rem

Re: [PULL v2 00/47] virtio,pc,pci: features, cleanups, fixes

2022-03-07 Thread Peter Maydell
On Mon, 7 Mar 2022 at 17:06, Peter Maydell wrote: > > On Mon, 7 Mar 2022 at 10:01, Michael S. Tsirkin wrote: > > > > The following changes since commit 6629bf78aac7e53f83fd0bcbdbe322e2302dfd1f: > > > > Merge remote-tracking branch > > 'remotes/pmaydell/tags/pull-target-arm-20220302' into stagi

Re: [PULL v2 00/47] virtio,pc,pci: features, cleanups, fixes

2022-03-07 Thread Peter Maydell
On Mon, 7 Mar 2022 at 10:01, Michael S. Tsirkin wrote: > > The following changes since commit 6629bf78aac7e53f83fd0bcbdbe322e2302dfd1f: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20220302' into staging (2022-03-03 > 14:46:48 +) > > are available in the Git re

[PULL v2 00/47] virtio,pc,pci: features, cleanups, fixes

2022-03-07 Thread Michael S. Tsirkin
The following changes since commit 6629bf78aac7e53f83fd0bcbdbe322e2302dfd1f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20220302' into staging (2022-03-03 14:46:48 +) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags